Default --rop to 5 if not specified (#65)

Author: 0vercl0k

src/rp/main.cpp

@@ -71,6 +71,14 @@ int main(int argc, char *argv[]) {
       fmt::print("You are currently using the version {} of rp++.\n", VERSION);
     }
 
+    // It has been confusing for users to run & see no rop gadget displayed..so
+    // we'll default the gadget length setting for them.
+    if (g_opts.display == 0 && g_opts.rop == 0) {
+      fmt::print("No rop gadget length was specified via --rop, so setting "
+                 "it to 5..\n");
+      g_opts.rop = 5;
+    }
+
     Program p(g_opts.file, g_opts.raw);
     if (g_opts.display >= VERBOSE_LEVEL_1 &&
         g_opts.display <= VERBOSE_LEVEL_3) {

src/rp/ropsearch_algorithm.cpp

@@ -117,9 +117,8 @@ void find_rop_gadgets(const std::vector<uint8_t> &section, const uint64_t vaddr,
     InstructionInformation ret_instr = disass_engine.disass(
         data + offset, size - offset, SafeIntAdd(vaddr, offset), ret);
 
-    // OK either this is an unknow opcode & we goto the next one Or the
-    // instruction encountered is too long & we also goto the next one in that
-    // case
+    // OK either this is an unknow opcode or the instruction is too long; in
+    // either case we goto the next one.
     if (ret == UnknownInstruction || ret == OutOfBlock) {
       continue;
     }