List of comments post-merge from PR #1846. - [ ] Check batch expiration (https://github.com/0xMiden/node/pull/1846#discussion_r3016641419) - [ ] Explain inputs in `proto` schema (https://github.com/0xMiden/node/pull/1846#discussion_r3018777324 and https://github.com/0xMiden/node/pull/1846#discussion_r3018803389) - [x] Possibly invalid or incomplete comment (https://github.com/0xMiden/node/pull/1846#discussion_r3018820817, https://github.com/0xMiden/node/pull/1846#discussion_r3019099058, https://github.com/0xMiden/node/pull/1846#discussion_r3019081764) - #1992 - #1993 - #1994 - [ ] Improve selection process to avoid allocating in a loop (https://github.com/0xMiden/node/pull/1846#discussion_r3002615484) - [x] Transaction bi-maps should be a single struct (https://github.com/0xMiden/node/pull/1846#discussion_r3019040224) - [x] Doc comment for `append_user_batch` (https://github.com/0xMiden/node/pull/1846#discussion_r3019048275) - [x] User + internal batches as nomenclature (https://github.com/0xMiden/node/pull/1846#discussion_r3019050890, https://github.com/0xMiden/node/pull/1846#discussion_r3019082795) - [x] Nits (https://github.com/0xMiden/node/pull/1846#discussion_r3019113856) More medium-long term issues: - [ ] https://github.com/0xMiden/node/pull/1846#discussion_r3019005512 - [ ] https://github.com/0xMiden/node/pull/1846#discussion_r3019020898 - [ ] https://github.com/0xMiden/node/pull/1846#discussion_r3019031689
List of comments post-merge from PR #1846.
protoschema (feat: user batch support #1846 (comment) and feat: user batch support #1846 (comment))append_user_batch(feat: user batch support #1846 (comment))More medium-long term issues: