Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate variable declaration #265

Open
tohrnii opened this issue Apr 24, 2023 · 3 comments
Open

Validate variable declaration #265

tohrnii opened this issue Apr 24, 2023 · 3 comments
Labels

Comments

@tohrnii
Copy link
Contributor

tohrnii commented Apr 24, 2023

Currently we don't check if a declared variable is valid. This check is only done while inserting the subgraph corresponding to the variable expression if this variable is used. Even though if the declared variable isn't used it is dead code, it would be good to still do the validation.

@tohrnii tohrnii added the IR label Apr 24, 2023
@bobbinth
Copy link
Contributor

bobbinth commented Jul 3, 2023

@tohrnii - is this still relevant?

@tohrnii
Copy link
Contributor Author

tohrnii commented Jul 3, 2023

Actually I'm not sure as I'm not caught up with the latest changes yet. Maybe @bitwalker or @grjte could confirm.

@bitwalker
Copy link
Contributor

During inlining we strip all unused lets, and it is no longer possible to express trailing lets. However we don't currently raise a warning when a variable is unused, though we could certainly add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants