Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider optionally allowing named segments as evaluator parameters #268

Open
tohrnii opened this issue Apr 24, 2023 · 0 comments
Open

Consider optionally allowing named segments as evaluator parameters #268

tohrnii opened this issue Apr 24, 2023 · 0 comments

Comments

@tohrnii
Copy link
Contributor

tohrnii commented Apr 24, 2023

Now that we have made evaluators more general in terms of segments it can accept, it may be helpful to optionally allow named segments in parameters. For example, consider a trace with 5 segments (segment_0, segment_1, segment_2, segment_3, segment_4) and an evaluator that takes first and last segment.

Something like ev evaluator([a, b], [], [], [], [c, d]) is probably prone to error. We should also allow users to do something like:
ev evaluator(segment_0: [a, b], segment_4: [c, d]).

This issue is not of high priority though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant