Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for codegen #9

Open
grjte opened this issue Oct 19, 2022 · 3 comments
Open

Add unit tests for codegen #9

grjte opened this issue Oct 19, 2022 · 3 comments
Assignees
@grjte
Labels
tests

Comments

@grjte
Copy link
Contributor

grjte commented Oct 19, 2022 •
edited
Loading

The initial codegen is missing some things and does not yet produce valid code, since it was primarily targeting generation of constraints.

The following should be added:

  • any missing required codegen in order for output files to be valid
  • Unit tests for each of the generated methods / structs
@grjte
Copy link
Contributor Author

grjte commented Oct 19, 2022

This can be started once #8 is merged

@grjte grjte added bug Something isn't working tests labels Oct 19, 2022
@grjte grjte added the v0.1 label Oct 19, 2022
@tohrnii tohrnii mentioned this issue Oct 23, 2022
Closed
@grjte grjte changed the title Complete codegen and add tests Add unit tests for codegen Oct 26, 2022
@grjte
Copy link
Contributor Author

grjte commented Oct 26, 2022

@tohrnii since there are now multiple other issues where the remaining tasks are for codegen (#10, #11, #14, #15 ), I'm renaming this one to be specifically for unit testing, and I'm going to unassign it from you for now, since it's lower priority than the other items we need to finish.

@grjte
Copy link
Contributor Author

grjte commented Oct 26, 2022

When we figure out our unit testing structure, it would be good to add a unit test for the issue resolved in #35

@tohrnii tohrnii mentioned this issue Oct 27, 2022
Merged
@grjte grjte removed v0.1 bug Something isn't working labels Oct 28, 2022
@grjte grjte self-assigned this Nov 22, 2022
@grjte grjte mentioned this issue Nov 22, 2022
Closed
@tohrnii tohrnii added the v0.2 label Nov 25, 2022
@grjte grjte mentioned this issue Nov 25, 2022
Merged
@tohrnii tohrnii mentioned this issue Nov 28, 2022
Merged
14 tasks
@tohrnii tohrnii removed the v0.2 label Feb 13, 2023
paracetamolo pushed a commit that referenced this issue Feb 14, 2025
@Leo-Besancon @Soulthym
Add various MIR documentation (#9)
471b15c 
* document derive-ir helpers

* document Visitor

* document Link and BackLink

* Small tweaks and fix typos in documentation for MirGraph, Accessor

* documentation for Root, Evaluator, Function and Parameter

* documentation for Op

* cargo fmt + clippy

* documentation for get_inner, get_inner_mut helpers

* documentation for Op::debug and tweak docs

* documentation tweaks for Root

* documentation for Node

* documentation tweaks

* documentation for Owner + implement missing as_node

* documentation for Child and Parent methods

* documentation tweaks for Builder

* documentation tweaks for Value

* refactor: Move parameter in ops module

---------

Co-authored-by: Thybault Alabarbe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grjte grjte

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grjte @tohrnii