Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent with_entries mismatches sequential implementation due to unsorted keys in multiple-entry leaves #387

Open
krushimir opened this issue Feb 21, 2025 · 0 comments
Milestone

Comments

@krushimir
Copy link

krushimir commented Feb 21, 2025

The concurrent implementation of with_entries fails to correctly construct leaves when multiple entries are stored in a single leaf and keys are not sorted before constructing the leaf.

This causes inconsistencies between the sequential and concurrent implementations.

The issue arises due to a behavior discrepancy between SmtLeaf::insert and SmtLeaf::new_multiple. Note that SmtLeaf::new_multiple doesn't mention sorted input as requirement.

Will be addressed in #385

@bobbinth bobbinth added this to the v0.14.0 milestone Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants