Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom error reporting in traces #683

Open
Mirko-von-Leipzig opened this issue Feb 11, 2025 · 1 comment
Open

Custom error reporting in traces #683

Mirko-von-Leipzig opened this issue Feb 11, 2025 · 1 comment
Labels
telemetry Relates to tracing and open-telemetry
Milestone
v0.9

Comments

@Mirko-von-Leipzig
Copy link
Contributor

TL;DR: tracing defaults to using the Display implementation for errors which means that we can't get an error report.

See this comment chain for some initial spelunking results.

#678 should help us at the root span level, but unfortunately there doesn't appear to be an option for #[instrument] without creating a custom attribute macro.

Investigate further and/or attempt the macro.
@bobbinth bobbinth added this to the v0.9 milestone Feb 11, 2025
@Mirko-von-Leipzig Mirko-von-Leipzig added the telemetry Relates to tracing and open-telemetry label Feb 13, 2025
@Mirko-von-Leipzig
Copy link
Contributor Author

#678 added an error report via the span extension trait. #[instrument] is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
telemetry Relates to tracing and open-telemetry
Projects
None yet
Milestone
v0.9
Development

No branches or pull requests
2 participants
@bobbinth @Mirko-von-Leipzig