Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC methods for network transactions #695

Open
Mirko-von-Leipzig opened this issue Feb 14, 2025 · 1 comment
Open

gRPC methods for network transactions #695

Mirko-von-Leipzig opened this issue Feb 14, 2025 · 1 comment
Labels
network transactions Relates to the network transactions feature
Milestone

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Mirko-von-Leipzig commented Feb 14, 2025

See #692 for full context.

Define a new network-transaction service with two methods:

  1. Receive new network note (can just be a plain note for now)
  2. Receive status update for network transaction (tx_id + Status::Committed | Status::Failed). Consider including block height and error reason respectively.

The new component also needs access to the store and block-producer APIs but only requires one additional store method to retrieve existing network notes on startup.

Consider making this new method a stream - could be good to see how it fits in, considering we want to use it elsewhere potentially.

Somewhat blocked by

@Mirko-von-Leipzig Mirko-von-Leipzig added the network transactions Relates to the network transactions feature label Feb 14, 2025
@bobbinth
Copy link
Contributor

bobbinth commented Feb 15, 2025

Receive status update for network transaction (tx_id + Status::Committed | Status::Failed). Consider including block height and error reason respectively.

As I mentioned in a comment to one of the other related issues, this endpoint can accept all transactions (tx_id + status is pretty light-weight) and then filter out transactions it doesn't care about internally.

Receive new network note (can just be a plain note for now)

We may also want to add tx_id for every such note (i.e., transaction ID for the transaction which generated this note). Won't be too useful now, but later on, this would allow us to track the node's progress through the mempool.

@bobbinth bobbinth added this to the v0.9 milestone Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network transactions Relates to the network transactions feature
Projects
None yet
Development

No branches or pull requests

2 participants