Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove verify-tx-proofs config item #718

Open
Mirko-von-Leipzig opened this issue Feb 23, 2025 · 3 comments
Open

Remove verify-tx-proofs config item #718

Mirko-von-Leipzig opened this issue Feb 23, 2025 · 3 comments
Assignees
@Mirko-von-Leipzig
Milestone
v0.8

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Mirko-von-Leipzig commented Feb 23, 2025 •
edited
Loading

Not for this PR, but I wonder if we should just get rid of this setting and explicitly state that the block producer trust that it receives valid transaction proofs (these will be verified during batch construction anyway). @Mirko-von-Leipzig let's create an issue for this (unless we already have one).

Originally posted by @bobbinth in #701 (comment)
@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this issue Feb 23, 2025
Open
@bobbinth bobbinth added this to the v0.8 milestone Feb 23, 2025
@Mirko-von-Leipzig
Copy link
Contributor Author

Can be done as part of #676

@bobbinth
Copy link
Contributor

Should we move #676 to this milestone then?

@Mirko-von-Leipzig
Copy link
Contributor Author

Should we move #676 to this milestone then?

Depends how much time we have - just removing this would be quick, #676 will be a few days work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mirko-von-Leipzig Mirko-von-Leipzig

Labels
None yet
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
2 participants
@bobbinth @Mirko-von-Leipzig