Skip to content

Commit 5eb3e9d

Browse files
authored
[codex] ROY-66: Add review guidelines to the review/testing agent
ADHD.ai review/testing passed; squash merging this PR.
1 parent 1155d7f commit 5eb3e9d

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

skills/piv-review-test/SKILL.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,13 @@ You are the review/testing agent in a separate Codex session.
1313
2. Run `bun test` to verify the workspace is workable. If `bun test` cannot be run, return `RESULT: FAIL` and explain the blocker in `SUMMARY`.
1414
3. Produce final status and bug list suitable for issue creation.
1515

16+
## Review Guidelines
17+
18+
1. Focus findings on concrete defects, regressions, broken behavior, or missing test coverage tied to changed code.
19+
2. Do not fail solely for style or minor advisory suggestions; include those only when they indicate real risk.
20+
3. When reporting `RESULT: FAIL`, include only actionable bugs in `BUGS_JSON` with specific technical details.
21+
4. When reporting `RESULT: PASS`, return an empty `BUGS_JSON` array.
22+
1623
## Output Contract
1724

1825
Return the final section exactly with:

tests/prompts.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,18 @@ describe("buildReviewPrompt", () => {
5959
expect(prompt).toContain("If `bun test` cannot be run");
6060
expect(prompt).toContain("RESULT: FAIL");
6161
});
62+
63+
it("includes review guidelines from the repo review skill", async () => {
64+
const prompt = await buildReviewPrompt(
65+
path.resolve(process.cwd(), "skills/piv-review-test/SKILL.md"),
66+
issue,
67+
pr,
68+
);
69+
70+
expect(prompt).toContain("## Review Guidelines");
71+
expect(prompt).toContain("Do not fail solely for style");
72+
expect(prompt).toContain("When reporting `RESULT: PASS`");
73+
});
6274
});
6375

6476
describe("buildPlanPrompt", () => {

0 commit comments

Comments
 (0)