update (#275)

* update

* Fix backup directory permissions

Author: 0xroylee

packages/db/scripts/backup.ts

@@ -1,7 +1,9 @@
-import { cp, readFile, stat } from "node:fs/promises";
+import { chmod, cp, readFile, rm, stat } from "node:fs/promises";
 import path from "node:path";
 import { printCliError, readOptionValue, resolveDatabasePath } from "./cli";
 
+const COPIED_RUNTIME_FILES = ["postmaster.pid", "postmaster.opts"];
+
 export interface BackupDatabaseOptions {
 	dbPath?: string;
 	now?: Date;
@@ -61,9 +63,27 @@ export async function backupDatabase(
 		throw new Error(`Backup path already exists: ${backupPath}`);
 	}
 	await cp(sourcePath, backupPath, { recursive: true });
+	await copyDirectoryPermissions(sourcePath, backupPath);
+	await removeCopiedRuntimeFiles(backupPath);
 	return { backupPath, sourcePath };
 }
 
+async function copyDirectoryPermissions(
+	sourcePath: string,
+	backupPath: string,
+): Promise<void> {
+	const sourceStats = await stat(sourcePath);
+	await chmod(backupPath, sourceStats.mode & 0o777);
+}
+
+async function removeCopiedRuntimeFiles(backupPath: string): Promise<void> {
+	await Promise.all(
+		COPIED_RUNTIME_FILES.map((fileName) =>
+			rm(path.join(backupPath, fileName), { force: true }),
+		),
+	);
+}
+
 async function ensureClusterIsStopped(sourcePath: string): Promise<void> {
 	const pidPath = path.join(sourcePath, "postmaster.pid");
 	let pid: number | undefined;

packages/db/tests/database-backup-scripts.test.ts

@@ -0,0 +1,54 @@
+import { describe, expect, it } from "bun:test";
+import { stat, writeFile } from "node:fs/promises";
+import path from "node:path";
+import { backupDatabase } from "../scripts/backup";
+import { migrateDatabase } from "../scripts/migrate";
+import {
+	createDatabasePort,
+	readMigrationCount,
+	withDatabasePath,
+} from "./helpers/database-script-helpers";
+
+const EMBEDDED_POSTGRES_TEST_TIMEOUT_MS = 20_000;
+
+describe("database backup script", () => {
+	it(
+		"omits stale PostgreSQL runtime files from copied backups",
+		() =>
+			withDatabasePath(async (dbPath) => {
+				await migrateDatabase({ dbPath, port: await createDatabasePort() });
+				const staleRuntimeFiles = ["postmaster.pid", "postmaster.opts"];
+
+				for (const fileName of staleRuntimeFiles) {
+					await writeFile(path.join(dbPath, fileName), "stale runtime state");
+				}
+
+				const result = await backupDatabase({
+					dbPath,
+					now: new Date("2026-05-20T01:02:03.004Z"),
+				});
+
+				for (const fileName of staleRuntimeFiles) {
+					await expectPath(path.join(dbPath, fileName), true);
+					await expectPath(path.join(result.backupPath, fileName), false);
+				}
+				await expect(
+					readMigrationCount(result.backupPath),
+				).resolves.toBeGreaterThan(0);
+			}),
+		EMBEDDED_POSTGRES_TEST_TIMEOUT_MS,
+	);
+});
+
+async function expectPath(filePath: string, exists: boolean): Promise<void> {
+	await expect(pathExists(filePath)).resolves.toBe(exists);
+}
+
+async function pathExists(filePath: string): Promise<boolean> {
+	try {
+		await stat(filePath);
+		return true;
+	} catch {
+		return false;
+	}
+}