Skip to content

Persist Codex model settings in onboard instance config #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xroylee merged 1 commit into from
May 29, 2026
Merged

Persist Codex model settings in onboard instance config #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/cli/src/features/onboard/onboard-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ export async function writeOnboardFiles(
},
draft.instance,
);
instanceConfig.codex = {
models: { ...draft.codex.models },
...(draft.codex.reasoningEfforts
? { reasoningEfforts: { ...draft.codex.reasoningEfforts } }
: {}),
};
if (existingInstanceConfig.ok && existingInstanceConfig.config.plugins) {
instanceConfig.plugins = existingInstanceConfig.config.plugins;
}
Expand Down
19 changes: 19 additions & 0 deletions packages/cli/tests/onboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,25 @@ describe("onboard helpers", () => {
});
});

it("writes Codex model settings into the instance config during onboard", async () => {
const tempDir = await mkdtemp(
path.join(process.cwd(), ".tmp-onboard-test-"),
);

try {
await writeOnboardFiles(tempDir, draft);
const loaded = await loadInstanceConfig(tempDir);
expect(loaded.ok).toBe(true);
if (!loaded.ok) return;
expect(loaded.config.codex?.models).toEqual(draft.codex.models);
expect(loaded.config.codex?.reasoningEfforts).toEqual(
draft.codex.reasoningEfforts,
);
} finally {
await rm(tempDir, { recursive: true, force: true });
}
});

it("uses low as default planning reasoning effort", () => {
expect(DEFAULT_REASONING_EFFORTS.plan).toBe("low");
});
Expand Down
Loading