Add LICENCE, CONTRIBUTING.md

Also rework the README a bit, and remove lines in `wm.c` that were added
by mistake previously.

Author: 29jm

CONTRIBUTING.md

@@ -0,0 +1,77 @@
+Contributions are much appreciated!
+
+## Table of contents
+
++ [Reporting bugs](#reporting-bugs)
++ [Proposing features or improvements](#proposing-features-or-improvements)
++ [Contributing pull requests](#contributing-pull-requests)
++ [Coding guidelines](#coding-guidelines)
+
+## Reporting bugs
+
++ Open one issue per bug
++ Specify the distro you're using, in particular if it's a build system bug
++ Provide steps to reproduce the bug
++ Provide the expected behavior if it's unclear
+
+## Proposing features or improvements
+
+Please do! Developers tend to develop blind spots after a while, new ideas are welcome. Even if the proposed feature was on the roadmap already, it doesn't hurt to open an issue for it, plus it can be expanded on there.
+
+## Contributing pull requests
+
++ Make sure there is a corresponding issue in the tracker, create one if needed
++ If you need help, ask
+    + Even if you don't, the project owner will pop up after a while with unsolicited advice
++ Read the **coding guidelines** in the [next section](#coding-guidelines) of this page
++ Consult this project's wiki, there are rare cases where it may help
++ Open your PR to get feedback
+    + feel free to open it early as a work-in-progress
++ It'll get merged once approved!
+    + Intermediate commits may be squashed into one when merging if they're not directly related to the purpose of the PR: you can rebase your branch yourself if you wish to clean its commits yourself
+
+## Coding guidelines
+
+Readability is considered important; try to keep the coding style uniform. Here are the guidelines in use:
+
++ indent using four spaces
++ use snake_case at all times
++ curly braces on the same line in all cases: `if (foo) {`, etc...
+    + put a space before curly braces
++ curly braces for single line `if`s `for`s and `while`s
++ a space between keywords and their parentheses: `if ()`, `for ()`
+    + except when they behave like functions: `sizeof()`, `offsetof()`
++ spaces around arithmetic operators: `a + b % c == 0`
++ pointers' `*` are put close to the type: `type_t* ptr = NULL`;
++ a blank line before and after control structures:
+  ```c
+  int blah = bar();
+
+  if (blah) {
+      ...;
+  }
+
+  ...;
+  ```
+    + except when the previous line is also a control structure, e.g. nested loops, an `if` within a loop, etc...
++ no extra blank lines otherwise, or trailing whitespace
++ use sized `ints` within the kernel: `uint32_t`, `uint8_t` etc... or their signed versions if needed
++ prefer lines that fit within 80-90 columns if possible
+
+Example taken from [kernel/src/misc/wm/wm.c](https://github.com/29jm/SnowflakeOS/blob/022fc799b6841aa1365b28ac53832bb2f1cefc2f/kernel/src/misc/wm/wm.c#L406-L419):
+```c
+/* Return the window iterator corresponding to the given id, NULL if none match.
+ */
+list_t* wm_get_window(uint32_t id) {
+    list_t* iter;
+    wm_window_t* win;
+
+    list_for_each(iter, win, &windows) { // counts as a `for` loop
+        if (win->id == id) {
+            return iter;
+        }
+    }
+
+    return NULL;
+}
+```

LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2015-2020 Johan Manuel, et. al.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

README.md

@@ -21,9 +21,9 @@ A hobby OS to help me learn about kernel stuff, to eventually get into linux ker
 
 I aim to make the code readable and well-organized. A blog follows the development of this project, here https://jmnl.xyz/.
 
-## Dependencies
+## Building & running
 
-### Packages
+### Dependencies
 
 Install the following packages:
 
@@ -67,17 +67,18 @@ If your distro provides you with a cross compiler, you may want to save time and
 
 You may edit `HOST`, or hardcode the executables names directly.
 
-## Running SnowflakeOS
+### Running SnowflakeOS
 
 Run either
 
     make qemu # or
     make bochs
 
-to test SnowflakeOS.
+to test SnowflakeOS in a VM.
 
-## Installing SnowflakeOS
+Testing this project on real hardware is possible. You can copy `SnowflakeOS.iso` to an usb drive using `dd`, like you would when making a live usb of another OS, and boot it directly.  
+Note that this is rarely ever tested, who knows what it'll do :) I'd love to hear about it if you try this, on which hardware, etc...
 
-Testing this project on real hardware is possible. You can copy `SnowflakeOS.iso` to an usb drive using `dd`, like you would when making a live usb of another OS, and boot it directly.
+## Contributing
 
-Note that this is rarely ever tested, who knows what it'll do :) I'd love to hear about it if you try this, on which hardware, etc...
+Contributions are most welcome, in any form! Consult `CONTRIBUTING.md` and this project's wiki for guidance.

kernel/src/misc/wm/wm.c

@@ -67,10 +67,6 @@ uint32_t wm_open_window(fb_t* buff, uint32_t flags) {
     wm_assign_z_orders();
     wm_raise_window(win);
 
-    char str[20] = "/wm/";
-    itoa(win->id, str+strlen(str), 10);
-    fs_open(str, O_CREAT);
-
     return win->id;
 }
 
@@ -90,10 +86,6 @@ void wm_close_window(uint32_t win_id) {
         }
 
         wm_refresh_partial(rect);
-
-        char str[20] = "/wm/";
-        itoa(win_id, str+strlen(str), 10);
-        fs_unlink(str);
     } else {
         printke("close: failed to find window of id %d", win_id);
     }