Skip to content

Get teamspace member through IDP endpoint #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 of 9 tasks
carmenfan opened this issue Mar 28, 2025 · 0 comments
Open
5 of 9 tasks

Get teamspace member through IDP endpoint #5480

carmenfan opened this issue Mar 28, 2025 · 0 comments
Assignees

Comments

@carmenfan
Copy link
Member

carmenfan commented Mar 28, 2025

Description

Product issue: https://github.com/3drepo/3D-Repo-Product-Team/issues/720

For details, see Product issue.

In summary:

  • We want to rewrite get teamspace members logic to get this information from frontegg
    • This will return userIds from frontegg, we would want to turn all the userIds into usernames
    • There may be users that are not recognised by 3D Repo from this request, those users should then be processed and a user entry needs to be created (similar to when someone we don't know logged in)
  • We will need to make sure v4 logic also do the same thing (easiest thing is probably to rewrite them to v5 functions)
  • We want to clean up any old logic that is reading/writing teamspace access to system.users
  • We will need to make sure utility scripts related to teamspace memberships are also rewired

For invitations, unlike previous implementation, these users will be created an account on their behalf so it will appear in the list of users from frontegg API. We want to filter those users out when we are getting the teamspace members so they will not be treated as if they have accepted the invite. This should be distinguishable from the state of the user provided by the frontegg api.

Goals

  • As a 3D Repo Admin, I want to control teamspace access through frontegg panel.
  • As a 3D Repo Admin, I want to make sure there is only one place storing teamspace membership so there is no risk of data going out of sync.
  • As a Teamspace Admin, I only want to see actual users in this list and invitees should stay as a pending invite

Tasks

  • identify and make changes in the v5 to accommodate using frontegg and return the same output
  • update v5 tests to reflect the changes if necessary
  • identify and update the v4 logic for getTeamspaceMembers
  • update necessary v4 tests to reflect the changes
  • identify and update utility scripts to reflect the changes
  • identify and clean up legacy read/write teamspace access to system.users

Related Resources

Frontegg API: https://developers.frontegg.com/api/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants