Use Ubuntu Noble instead of Focal

[Charence]

Upgrade from 20.04 to 24.04

[Charence]

Compilation fails: https://app.travis-ci.com/github/3drepo/3drepobouncer/jobs/630829248?serverType=git

In file included from /home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector.h:21:
/home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector3d.h:38:42: error: expected unqualified-id before ‘const’
   38 |                         _RepoVector3D<T>(const T x = 0, const T y = 0, const T z = 0) : x(x), y(y), z(z) {}
      |                                          ^~~~~
/home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector3d.h:38:42: error: expected ‘)’ before ‘const’
   38 |                         _RepoVector3D<T>(const T x = 0, const T y = 0, const T z = 0) : x(x), y(y), z(z) {}
      |                                         ~^~~~~
      |                                          )
/home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector3d.h:39:42: error: expected unqualified-id before ‘const’
   39 |                         _RepoVector3D<T>(const std::vector<T> &v)
      |                                          ^~~~~
/home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector3d.h:39:42: error: expected ‘)’ before ‘const’
   39 |                         _RepoVector3D<T>(const std::vector<T> &v)
      |                                         ~^~~~~
      |                                          )
/home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector3d.h:47:42: error: expected unqualified-id before ‘const’
   47 |                         _RepoVector3D<T>(const _RepoVector3D<From>& v)
      |                                          ^~~~~
/home/travis/build/3drepo/3drepobouncer/ifcUtils/../bouncer/src/repo/lib/datastructure/repo_vector3d.h:47:42: error: expected ‘)’ before ‘const’
   47 |                         _RepoVector3D<T>(const _RepoVector3D<From>& v)
      |                                         ~^~~~~
      |                                          )
[  6%] Linking CXX shared library SvgExport.tx
make[2]: *** [ifcUtils/CMakeFiles/ifcUtils_2x3.dir/build.make:90: ifcUtils/CMakeFiles/ifcUtils_2x3.dir/repo_ifc_utils_tree_parser.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [ifcUtils/CMakeFiles/ifcUtils_4.dir/build.make:90: ifcUtils/CMakeFiles/ifcUtils_4.dir/repo_ifc_utils_tree_parser.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[  6%] Built target SvgExport
make[2]: *** [ifcUtils/CMakeFiles/ifcUtils_2x3.dir/build.make:76: ifcUtils/CMakeFiles/ifcUtils_2x3.dir/repo_ifc_utils_geometry_handler.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:933: ifcUtils/CMakeFiles/ifcUtils_2x3.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [ifcUtils/CMakeFiles/ifcUtils_4.dir/build.make:76: ifcUtils/CMakeFiles/ifcUtils_4.dir/repo_ifc_utils_geometry_handler.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:959: ifcUtils/CMakeFiles/ifcUtils_4.dir/all] Error 2
[  6%] Linking CXX static library ../../../lib/libgtestd.a
[  6%] Built target gtest
make: *** [Makefile:136: all] Error 2
The command "sudo make -j8 install" exited with 2.

[carmenfan]

@Charence this is probably to do with the default gcc version it's using

It's also a moving block right now since @sebjf is working on #740

Can you separate the 2 pieces of work? lets upgrade mongo to v8 as a separate issue to upgrading linux (the mongo stuff should have less complications), and maybe @sebjf can give better advice on what gcc version etc is needed with all the recent changes (or would it be easier if you do it @sebjf ?)

[Charence]

@carmenfan Yes, I just spoke to @sebjf about it and he mentioned

the gcc toolchain will have been updated on 24.04 so its using c++20 as the default probably. in newer gcc versions its no longer allowed for templated classes to provide just .
this was fixed in 729, but thats not been reviewed yet

and

as for what to do for the moment... try to force it to use c++17?
perhaps its easiest to just upgrade in step

[carmenfan]

@Charence as I said, let's park this for now and upgrade mongo in a separate issue.

No point trying to force everything in the old version when Sebastian already fixed it

[Charence]

Upgrade MongoDB in #742

[Charence]

Now getting some different compilation errors:

39.57 -- $SYNCHRO_READER_ROOT defined: /home/bouncer/3drepoSynchroReader
39.58 -- SYNCHRO_READER installation found.
39.58 -- SYNCHRO_READER_INCLUDE_DIR: /home/bouncer/3drepoSynchroReader/include
39.58 -- SYNCHRO_READER_LIBRARIES: debug;/home/bouncer/3drepoSynchroReader/lib/lib3drepoSynchroReader_4_0_2.so;optimized;/home/bouncer/3drepoSynchroReader/lib/lib3drepoSynchroReader_4_0_2.so
39.58 -- $THRIFT_ROOT defined: /home/bouncer/thrift-0.12.0/
39.58 -- THRIFT installation found.
39.58 -- THRIFT_INCLUDE_DIR: /home/bouncer/thrift-0.12.0/include
39.58 -- THRIFT_LIBRARIES: debug;/home/bouncer/thrift-0.12.0/lib/libthrift.so;/home/bouncer/thrift-0.12.0/lib/libthriftz.so;optimized;/home/bouncer/thrift-0.12.0/lib/libthrift.so;/home/bouncer/thrift-0.12.0/lib/libthriftz.so
39.58 -- ZLIB installation found.
39.58 -- ZLIB_INCLUDE_DIR: /usr/include
39.58 -- ZLIB_LIBRARIES: debug;/usr/lib/x86_64-linux-gnu/libz.so;optimized;/usr/lib/x86_64-linux-gnu/libz.so
39.61 -- Configuring done (0.6s)
39.71 -- Generating done (0.1s)
39.72 -- Build files have been written to: /home/bouncer/3drepobouncer/build
39.75 [  3%] Building CXX object submodules/svgexport/CMakeFiles/SvgExport.dir/src/StdAfx.cpp.o
39.75 [  3%] Building CXX object log/CMakeFiles/log.dir/repo_broadcaster.cpp.o
39.75 [  3%] Building CXX object submodules/svgexport/CMakeFiles/SvgExport.dir/src/StdAfx_SvgExport.cpp.o
39.75 [  4%] Building CXX object submodules/svgexport/CMakeFiles/SvgExport.dir/src/2dExportDevice.cpp.o
39.75 [  5%] Building CXX object submodules/svgexport/CMakeFiles/SvgExport.dir/src/2dSupport.cpp.o
39.75 [  6%] Building CXX object log/CMakeFiles/log.dir/repo_log.cpp.o
39.76 [  7%] Building CXX object submodules/svgexport/CMakeFiles/SvgExport.dir/src/SvgExport.cpp.o
46.05 [  8%] Linking CXX shared library liblog.so
46.12 [  8%] Built target log
46.14 [ 12%] Building CXX object ifcUtils/CMakeFiles/ifcUtils_4.dir/repo_ifc_utils_tree_parser.cpp.o
46.14 [ 12%] Building CXX object ifcUtils/CMakeFiles/ifcUtils_2x3.dir/repo_ifc_utils_geometry_handler.cpp.o
46.14 [ 12%] Building CXX object ifcUtils/CMakeFiles/ifcUtils_4.dir/repo_ifc_utils_geometry_handler.cpp.o
46.14 [ 12%] Building CXX object ifcUtils/CMakeFiles/ifcUtils_2x3.dir/repo_ifc_utils_tree_parser.cpp.o
46.84 [ 13%] Linking CXX shared library SvgExport.tx
47.85 [ 13%] Built target SvgExport
54.23 [ 14%] Linking CXX shared library libifcUtils_2x3.so
54.36 [ 15%] Linking CXX shared library libifcUtils_4.so
54.61 [ 15%] Built target ifcUtils_2x3
54.78 [ 15%] Built target ifcUtils_4
54.80 [ 16%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp.o
54.80 [ 17%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/repo_database_handler_abstract.cpp.o
54.80 [ 18%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/__/submodules/asset_generator/src/repo_model_export_repobundle.cpp.o
54.80 [ 20%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/database/repo_query.cpp.o
54.80 [ 20%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/__/submodules/asset_generator/src/repo_line_mesh_factory.cpp.o
54.80 [ 21%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/fileservice/repo_data_ref.cpp.o
54.80 [ 22%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/fileservice/repo_file_handler_fs.cpp.o
54.80 [ 23%] Building CXX object bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/fileservice/repo_file_manager.cpp.o
55.79 In file included from /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_handler_abstract.h:23,
55.79                  from /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:22,
55.79                  from /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:23,
55.79                  from /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:17:
55.79 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/../repo_database_handler_abstract.h:75:56: error: 'unique_ptr' in namespace 'std' does not name a template type
55.79    75 |                                 using CursorPtr = std::unique_ptr<repo::core::handler::database::Cursor>;
55.79       |                                                        ^~~~~~~~~~
55.79 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/../repo_database_handler_abstract.h:26:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.79    25 | #include "repo/core/handler/database/repo_query_fwd.h"
55.79   +++ |+#include <memory>
55.79    26 | 
55.79 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/../repo_database_handler_abstract.h:304:46: error: 'unique_ptr' in namespace 'std' does not name a template type
55.79   304 |                                 virtual std::unique_ptr<database::BulkWriteContext> getBulkWriteContext(
55.79       |                                              ^~~~~~~~~~
55.79 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/../repo_database_handler_abstract.h:304:41: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.79   304 |                                 virtual std::unique_ptr<database::BulkWriteContext> getBulkWriteContext(
55.79       |                                         ^~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:38:90: error: 'std::weak_ptr' has not been declared
55.81    38 |                                         FileManager(const repo::lib::RepoConfig& config, std::weak_ptr<AbstractDatabaseHandler> handler);
55.81       |                                                                                          ^~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:38:103: error: expected ',' or '...' before '<' token
55.81    38 |                                         FileManager(const repo::lib::RepoConfig& config, std::weak_ptr<AbstractDatabaseHandler> handler);
55.81       |                                                                                                       ^
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:165:46: error: 'shared_ptr' in namespace 'std' does not name a template type
55.81   165 |                                         std::shared_ptr<AbstractDatabaseHandler> getDbHandler();
55.81       |                                              ^~~~~~~~~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:25:1: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.81    24 | #include "repo/lib/repo_config.h"
55.81   +++ |+#include <memory>
55.81    25 | 
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:167:46: error: 'weak_ptr' in namespace 'std' does not name a template type
55.81   167 |                                         std::weak_ptr<AbstractDatabaseHandler> dbHandler;
55.81       |                                              ^~~~~~~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:167:41: note: 'std::weak_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.81   167 |                                         std::weak_ptr<AbstractDatabaseHandler> dbHandler;
55.81       |                                         ^~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:168:46: error: 'shared_ptr' in namespace 'std' does not name a template type
55.81   168 |                                         std::shared_ptr<AbstractFileHandler> fsHandler;
55.81       |                                              ^~~~~~~~~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:168:41: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.81   168 |                                         std::shared_ptr<AbstractFileHandler> fsHandler;
55.81       |                                         ^~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:40:64: error: expected ')' before '<' token
55.81    40 |                                                 std::shared_ptr<FileManager> fileManager,
55.81       |                                                                ^
55.81       |                                                                )
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:39:57: note: to match this '('
55.81    39 |                                         BlobFilesHandler(
55.81       |                                                         ^
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:44:41: error: expected unqualified-id before ')' token
55.81    44 |                                         ) : manager(fileManager), database(database), collection(collection), metadata(metadata) {};
55.81       |                                         ^
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:51:46: error: 'shared_ptr' in namespace 'std' does not name a template type
55.81    51 |                                         std::shared_ptr<FileManager> getFileManager();
55.81       |                                              ^~~~~~~~~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:25:1: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.81    24 | #include "repo_data_ref.h"
55.81   +++ |+#include <memory>
55.81    25 | 
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:65:46: error: 'shared_ptr' in namespace 'std' does not name a template type
55.81    65 |                                         std::shared_ptr<FileManager> manager;
55.81       |                                              ^~~~~~~~~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:65:41: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.81    65 |                                         std::shared_ptr<FileManager> manager;
55.81       |                                         ^~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:67:46: error: 'shared_ptr' in namespace 'std' does not name a template type
55.81    67 |                                         std::shared_ptr<fileEntry> activeFile; //mem address we're currently writing to
55.81       |                                              ^~~~~~~~~~
55.81 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.h:67:41: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.81    67 |                                         std::shared_ptr<fileEntry> activeFile; //mem address we're currently writing to
55.81       |                                         ^~~
55.83 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp: In member function 'void repo::core::handler::fileservice::BlobFilesHandler::commitActiveFile()':
55.83 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:29:13: error: 'activeFile' was not declared in this scope; did you mean 'newActiveFile'?
55.83    29 |         if (activeFile) {
55.83       |             ^~~~~~~~~~
55.83       |             newActiveFile
55.83 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:30:17: error: 'manager' was not declared in this scope
55.83    30 |                 manager->uploadFileAndCommit(database, collection, activeFile->name, activeFile->buffer, metadata);
55.83       |                 ^~~~~~~
55.84 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:33:9: error: 'activeFile' was not declared in this scope; did you mean 'newActiveFile'?
55.84    33 |         activeFile.reset();
55.84       |         ^~~~~~~~~~
55.84       |         newActiveFile
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp: In member function 'void repo::core::handler::fileservice::BlobFilesHandler::newActiveFile()':
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:37:13: error: 'activeFile' was not declared in this scope; did you mean 'newActiveFile'?
55.85    37 |         if (activeFile) {
55.85       |             ^~~~~~~~~~
55.85       |             newActiveFile
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:41:9: error: 'activeFile' was not declared in this scope; did you mean 'newActiveFile'?
55.85    41 |         activeFile = std::make_shared<fileEntry>();
55.85       |         ^~~~~~~~~~
55.85       |         newActiveFile
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:41:27: error: 'make_shared' is not a member of 'std'
55.85    41 |         activeFile = std::make_shared<fileEntry>();
55.85       |                           ^~~~~~~~~~~
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:18:1: note: 'std::make_shared' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.85    17 | #include "repo_blob_files_handler.h"
55.85   +++ |+#include <memory>
55.85    18 | #include "repo/lib/datastructure/repo_uuid.h"
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:41:48: error: expected primary-expression before '>' token
55.85    41 |         activeFile = std::make_shared<fileEntry>();
55.85       |                                                ^
55.85 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:41:50: error: expected primary-expression before ')' token
55.85    41 |         activeFile = std::make_shared<fileEntry>();
55.85       |                                                  ^
55.86 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp: In member function 'repo::core::handler::fileservice::DataRef repo::core::handler::fileservice::BlobFilesHandler::insertBinary(const std::vector<unsigned char>&)':
55.86 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:47:14: error: 'activeFile' was not declared in this scope; did you mean 'newActiveFile'?
55.86    47 |         if (!activeFile || activeFile->buffer.size() + data.size() > MAX_FILE_SIZE_BYTES) {
55.86       |              ^~~~~~~~~~
55.86       |              newActiveFile
55.86 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:53:25: error: 'activeFile' was not declared in this scope; did you mean 'newActiveFile'?
55.86    53 |         auto startPos = activeFile->buffer.size();
55.86       |                         ^~~~~~~~~~
55.86       |                         newActiveFile
55.87 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp: In member function 'std::istream repo::core::handler::fileservice::BlobFilesHandler::fetchStream(const std::string&)':
55.87 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:63:9: error: 'manager' was not declared in this scope
55.87    63 |         manager->getFile(database, collection, name);
55.87       |         ^~~~~~~
55.87 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp: In member function 'std::vector<unsigned char> repo::core::handler::fileservice::BlobFilesHandler::readToBuffer(const repo::core::handler::fileservice::DataRef&)':
55.87 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:69:45: error: 'manager' was not declared in this scope
55.87    69 |                 readStreams[ref.fileName] = manager->getFileStream(database, collection, ref.fileName);
55.87       |                                             ^~~~~~~
55.88 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp: At global scope:
55.88 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:79:6: error: 'shared_ptr' in namespace 'std' does not name a template type
55.88    79 | std::shared_ptr<FileManager>  BlobFilesHandler::getFileManager()
55.88       |      ^~~~~~~~~~
55.88 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp:79:1: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
55.88    79 | std::shared_ptr<FileManager>  BlobFilesHandler::getFileManager()
55.88       | ^~~
56.08 make[2]: *** [bouncer/CMakeFiles/3drepobouncer.dir/build.make:118: bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/fileservice/repo_blob_files_handler.cpp.o] Error 1
56.08 make[2]: *** Waiting for unfinished jobs....
56.18 In file included from /home/bouncer/3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/export/../../../core/model/collection/repo_scene.h:26,
56.18                  from /home/bouncer/3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/export/repo_model_export_abstract.h:26,
56.18                  from /home/bouncer/3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/export/repo_model_export_web.h:27,
56.18                  from /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.h:31,
56.18                  from /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.cpp:27:
56.18 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:75:56: error: 'unique_ptr' in namespace 'std' does not name a template type
56.18    75 |                                 using CursorPtr = std::unique_ptr<repo::core::handler::database::Cursor>;
56.18       |                                                        ^~~~~~~~~~
56.18 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:26:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.18    25 | #include "repo/core/handler/database/repo_query_fwd.h"
56.18   +++ |+#include <memory>
56.18    26 | 
56.18 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:304:46: error: 'unique_ptr' in namespace 'std' does not name a template type
56.18   304 |                                 virtual std::unique_ptr<database::BulkWriteContext> getBulkWriteContext(
56.18       |                                              ^~~~~~~~~~
56.18 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:304:41: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.18   304 |                                 virtual std::unique_ptr<database::BulkWriteContext> getBulkWriteContext(
56.18       |                                         ^~~
56.23 In file included from /home/bouncer/3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/export/../../../core/model/collection/repo_scene.h:27:
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:38:90: error: 'std::weak_ptr' has not been declared
56.23    38 |                                         FileManager(const repo::lib::RepoConfig& config, std::weak_ptr<AbstractDatabaseHandler> handler);
56.23       |                                                                                          ^~~
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:38:103: error: expected ',' or '...' before '<' token
56.23    38 |                                         FileManager(const repo::lib::RepoConfig& config, std::weak_ptr<AbstractDatabaseHandler> handler);
56.23       |                                                                                                       ^
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:165:46: error: 'shared_ptr' in namespace 'std' does not name a template type
56.23   165 |                                         std::shared_ptr<AbstractDatabaseHandler> getDbHandler();
56.23       |                                              ^~~~~~~~~~
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:25:1: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.23    24 | #include "repo/lib/repo_config.h"
56.23   +++ |+#include <memory>
56.23    25 | 
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:167:46: error: 'weak_ptr' in namespace 'std' does not name a template type
56.23   167 |                                         std::weak_ptr<AbstractDatabaseHandler> dbHandler;
56.23       |                                              ^~~~~~~~
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:167:41: note: 'std::weak_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.23   167 |                                         std::weak_ptr<AbstractDatabaseHandler> dbHandler;
56.23       |                                         ^~~
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:168:46: error: 'shared_ptr' in namespace 'std' does not name a template type
56.23   168 |                                         std::shared_ptr<AbstractFileHandler> fsHandler;
56.23       |                                              ^~~~~~~~~~
56.23 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/fileservice/repo_file_manager.h:168:41: note: 'std::shared_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.23   168 |                                         std::shared_ptr<AbstractFileHandler> fsHandler;
56.23       |                                         ^~~
56.73 In file included from /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.cpp:22:
56.73 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:75:56: error: 'unique_ptr' in namespace 'std' does not name a template type
56.73    75 |                                 using CursorPtr = std::unique_ptr<repo::core::handler::database::Cursor>;
56.73       |                                                        ^~~~~~~~~~
56.73 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:26:1: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.73    25 | #include "repo/core/handler/database/repo_query_fwd.h"
56.73   +++ |+#include <memory>
56.73    26 | 
56.74 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:304:46: error: 'unique_ptr' in namespace 'std' does not name a template type
56.74   304 |                                 virtual std::unique_ptr<database::BulkWriteContext> getBulkWriteContext(
56.74       |                                              ^~~~~~~~~~
56.74 /home/bouncer/3drepobouncer/bouncer/src/repo/core/handler/repo_database_handler_abstract.h:304:41: note: 'std::unique_ptr' is defined in header '<memory>'; did you forget to '#include <memory>'?
56.74   304 |                                 virtual std::unique_ptr<database::BulkWriteContext> getBulkWriteContext(
56.74       |                                         ^~~
57.11 /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.cpp: In member function 'repo::lib::PropertyTree repo::manipulator::modelconvertor::RepoBundleExport::generateJSONMapping(const repo::core::model::SupermeshNode&, const repo_bundle_usage&)':
57.11 /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.cpp:563:13: error: 'isnan' was not declared in this scope
57.11   563 |         if (isnan(matStruct.shininess))
57.11       |             ^~~~~
57.11 /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.cpp:563:13: note: suggested alternatives:
57.11 In file included from /home/bouncer/3drepobouncer/bouncer/src/repo/lib/datastructure/repo_vector3d.h:25,
57.11                  from /home/bouncer/3drepobouncer/bouncer/src/repo/lib/datastructure/repo_vector.h:21,
57.11                  from /home/bouncer/3drepobouncer/bouncer/src/repo/core/model/bson/repo_bson_assets.h:25,
57.11                  from /home/bouncer/3drepobouncer/bouncer/src/repo/lib/datastructure/repo_structs.h:24,
57.11                  from /home/bouncer/3drepobouncer/bouncer/src/repo/core/model/bson/repo_bson_sequence.h:21,
57.11                  from /home/bouncer/3drepobouncer/bouncer/src/repo/manipulator/modelconvertor/export/../../../core/model/collection/repo_scene.h:28:
57.11 /usr/include/c++/13/cmath:1192:5: note:   'std::isnan'
57.11  1192 |     isnan(_Tp)
57.11       |     ^~~~~
57.11 /usr/include/c++/13/cmath:1171:3: note:   'std::isnan'
57.11  1171 |   isnan(float __x)
57.11       |   ^~~~~
57.12 /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.cpp:566:13: error: 'isnan' was not declared in this scope
57.12   566 |         if (isnan(matStruct.shininessStrength))
57.12       |             ^~~~~
57.12 /home/bouncer/3drepobouncer/submodules/asset_generator/src/repo_model_export_repobundle.cpp:566:13: note: suggested alternatives:
57.12 /usr/include/c++/13/cmath:1192:5: note:   'std::isnan'
57.12  1192 |     isnan(_Tp)
57.12       |     ^~~~~
57.12 /usr/include/c++/13/cmath:1171:3: note:   'std::isnan'
57.12  1171 |   isnan(float __x)
57.12       |   ^~~~~
57.41 make[2]: *** [bouncer/CMakeFiles/3drepobouncer.dir/build.make:174: bouncer/CMakeFiles/3drepobouncer.dir/src/repo/core/handler/repo_database_handler_abstract.cpp.o] Error 1
57.99 make[2]: *** [bouncer/CMakeFiles/3drepobouncer.dir/build.make:76: bouncer/CMakeFiles/3drepobouncer.dir/__/submodules/asset_generator/src/repo_model_export_repobundle.cpp.o] Error 1
63.20 make[1]: *** [CMakeFiles/Makefile2:707: bouncer/CMakeFiles/3drepobouncer.dir/all] Error 2
63.20 make: *** [Makefile:136: all] Error 2
------
Dockerfile:158
--------------------
 157 |     #compile 3drepobouncer libraries and util
 158 | >>> RUN echo -e "machine github.com\n login $TESTS_USER\n password $GITHUB_TOKEN" >~/.netrc && \
 159 | >>>         git clone --recurse-submodules -b ${app_3drepobouncer_version} https://3drepoinstaller:${GITHUB_TOKEN}@github.com/3drepo/3drepobouncer.git /home/bouncer/3drepobouncer && \
 160 | >>>         mkdir -p /home/bouncer/3drepobouncer/log && \
 161 | >>>         chown bouncer:bouncer /home/bouncer/3drepobouncer && \
 162 | >>>         mkdir -p /home/bouncer/3drepobouncer/build && \
 163 | >>>         cd /home/bouncer/3drepobouncer/build && \
 164 | >>>         if (( $LICENSE_CHECK>0 )); then export FLAG=ON; else export FLAG=OFF ; fi && \
 165 | >>>         cmake \
 166 | >>>               -DCMAKE_CXX_COMPILER=$CXX \
 167 | >>>               -DCMAKE_CXX_FLAGS=-Wno-deprecated-declarations -Wno-dev \
 168 | >>>               -DODA_SUPPORT=ON \
 169 | >>>               -DLICENSE_CHECK=${FLAG} \
 170 | >>>               -DSYNCHRO_SUPPORT=${DSYNCHRO_SUPPORT} \
 171 | >>>               -DCMAKE_BUILD_TYPE=Release \
 172 | >>>               -DCMAKE_INSTALL_PREFIX=/home/bouncer/bouncer_install ../ && \
 173 | >>>         make -j8 install && \
 174 | >>>         chown -R bouncer:bouncer /home/bouncer/3drepobouncer && \
 175 | >>>         chmod -R 555 /home/bouncer/3drepobouncer
 176 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c echo -e \"machine github.com\\n login $TESTS_USER\\n password $GITHUB_TOKEN\" >~/.netrc &&         git clone --recurse-submodules -b ${app_3drepobouncer_version} https://3drepoinstaller:${GITHUB_TOKEN}@github.com/3drepo/3drepobouncer.git /home/bouncer/3drepobouncer &&         mkdir -p /home/bouncer/3drepobouncer/log &&         chown bouncer:bouncer /home/bouncer/3drepobouncer &&         mkdir -p /home/bouncer/3drepobouncer/build &&         cd /home/bouncer/3drepobouncer/build &&         if (( $LICENSE_CHECK>0 )); then export FLAG=ON; else export FLAG=OFF ; fi &&         cmake               -DCMAKE_CXX_COMPILER=$CXX               -DCMAKE_CXX_FLAGS=-Wno-deprecated-declarations -Wno-dev               -DODA_SUPPORT=ON               -DLICENSE_CHECK=${FLAG}               -DSYNCHRO_SUPPORT=${DSYNCHRO_SUPPORT}               -DCMAKE_BUILD_TYPE=Release               -DCMAKE_INSTALL_PREFIX=/home/bouncer/bouncer_install ../ &&         make -j8 install &&         chown -R bouncer:bouncer /home/bouncer/3drepobouncer &&         chmod -R 555 /home/bouncer/3drepobouncer" did not complete successfully: exit code: 2
######################################################
Built on: 20250318184008
Git HEAD: a778ca07

[Charence]

FYI: Jammy (22.04) also has the same compilation issues.

[sebjf]

@Charence I am seeing the same thing on my new 24.04 vm - I am working on it now!

[sebjf]

I have got it to compile, but some of the dependencies have secondary dependencies that are too old (e.g. mongo driver, even though that was compiled recently, so I am going to recompile them as necessary on noble)

[Charence]

Cool! Thanks!

[sebjf]

@Charence, do you know what the situation is with thrift? When I try to compile synchro reader, it fails - I assume 3drepoSynchroReader is targeting a newer version of thrift that is on tests, but doesn't use any newer parts of the shared library?

[sebjf]

When I try to build 3drepoSynchroReader (because Boost is too old 🙄), I get the following

In file included from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.3/source/customThrift/synchroAPI/ISynchroIntegrationAPI.h:17,
                 from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.3/source/customThrift/synchroAPI/ISynchroIntegrationAPI.cpp:12:
/home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.3/source/customThrift/synchroAPI/SynchroIntegrationAPI_types.h:20:10: fatal error: thrift/TBinary.h: No such file or directory
   20 | #include <thrift/TBinary.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [plugins/6.3/CMakeFiles/Synchro_6.3.dir/build.make:104: plugins/6.3/CMakeFiles/Synchro_6.3.dir/source/customThrift/synchroAPI/ISynchroIntegrationAPI.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:656: plugins/6.3/CMakeFiles/Synchro_6.3.dir/all] Error 2
In file included from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.4/source/customThrift/synchroAPI/ISynchroIntegrationAPI.h:17,
                 from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.4/source/customThrift/synchroAPI/ISynchroIntegrationAPI.cpp:12:
/home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.4/source/customThrift/synchroAPI/SynchroIntegrationAPI_types.h:20:10: fatal error: thrift/TBinary.h: No such file or directory
   20 | #include <thrift/TBinary.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.5.1.5/source/customThrift/synchroAPI/ISynchroAdminAPI.h:17,
                 from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.5.1.5/source/customThrift/synchroAPI/ISynchroAdminAPI.cpp:12:
/home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.5.1.5/source/customThrift/synchroAPI/SynchroAdminAPI_types.h:20:10: fatal error: thrift/TBinary.h: No such file or directory
   20 | #include <thrift/TBinary.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.5.1.5/source/customThrift/synchroAPI/ISynchroIntegrationAPI.h:17,
                 from /home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.5.1.5/source/customThrift/synchroAPI/ISynchroIntegrationAPI.cpp:12:
/home/sebjf/bouncer/3drepoSynchroReaderBuild/plugins/6.5.1.5/source/customThrift/synchroAPI/SynchroIntegrationAPI_types.h:20:10: fatal error: thrift/TBinary.h: No such file or directory
   20 | #include <thrift/TBinary.h>
      |          ^~~~~~~~~~~~~~~~~~

However, even in the latest Thrift (0.21), I don't see that header...

EDIT: Nevermind I have got it compiling with USE_ORIGINAL_THRIFT - it was a CMake caching problem.

[sebjf]

OK I have it building and I can start the client (not run through the unit tests yet). I will package up the updated dependencies into a new folder in tests for noble.

[sebjf]

@Charence, do you want to give it another try? I have updated travis.yml as well so will be interesting to see if that works..

[Charence]

@sebjf Thanks! Looks like it has got much further on Travis but is failing on a Synchro test: https://app.travis-ci.com/github/3drepo/3drepobouncer/jobs/631500497

[sebjf]

Hmm not sure if this is because I built 3drepoSynchroReader with USE_ORIGINAL_THRIFT. Since thats the only failed test it's probably worth just waiting for @carmenfan to come back and say than try to guess!

[Charence]

@sebjf FYI I've managed to build this branch successfully using Docker on 24.04:

[sebjf]

@carmenfan @Charence, I printed the result of dlerror() in plugin loader & found the reason Synchro is failing is due to missing dependencies.

Once I made sure it could find the local ones, it began failing to load libssl.so.1.1, which will have been removed from 24.04 because it has been EOL'd.

Ubuntu's package manager how has thrift included, so we can use that version. However, after thrift 0.12.0 c98 was deprecated and the shims in stdcxx.h removed in favour of C++ features.

While this would otherwise be good news (no more Boost dependencies as well!), that header is used in the SynchroAPI auto generated files like this one: https://github.com/3drepo/SynchroReader/blob/9a9ef980899b88651a2c4039d0ee58aa38971a92/plugins/6.3/source/customThrift/synchroAPI/SynchroAPITypes_types.h#L26

Not sure whats best to do here. We could try to compile thrift 0.12 with OpenSSL 3. That feels like kicking the can down the road and might not even be possible. However it seems even the newest Synchro plugins (6.5.3.7) are still autogenerating by thrift 0.12 so if we tried to modify them, we'd end up having to do it for all future ones too until Synchro update their toolchain.

(Unless we generate those files from the thrift compiler? I don't know enough about Synchro!)

[sebjf]

FYI I have managed to compile thrift-0.12.0 under 24.04, and then the synchro reader plugins, and now they seem to load OK. The tests are still failing but they look like they're coming from 3drepobouncerTest proper and are to do with the tests environment on this new VM so I'll look into that next.

[carmenfan]

@sebjf Yea you guessed it 😆 I'm the one who generate the code in the originalThrift version of the library

Looks like you've resolved it now, but instructions are here if you ever need it https://github.com/3drepo/SynchroReader/wiki/Adding-new-versions-of-Synchro

With the synchro source here https://asitesol.sharepoint.com/sites/3DRepoTeamFolder/Shared%20Documents/Forms/AllItems.aspx?id=%2Fsites%2F3DRepoTeamFolder%2FShared%20Documents%2FRelease%2F3drepobouncer%2FSynchro&viewid=60884782%2D12a7%2D4f6f%2Db426%2Debefd8aef345

[sebjf]

Ah didn't check the wiki 🙈, thank you!

The reader with the newly built thrift 0.12.0 passes the unit tests so I can package that up & then that should be it. Good to know we are not stuck when that eventually stops working though!

[sebjf]

This is passing the unit and integration tests, but failing because like thrift, cryptolens (or a dependency) is linking against OpenSSL1. This is another thing I don't much about but will look into recompiling it as well...

[sebjf]

Hi @carmenfan, cryptoLens (3drepo_current) has built OK on noble so I've updated the tests repo and we'll see what travis does.

I only had to make one change, and that was to add <cstdint> to ActivationData.hpp as it seems g++13 no longer considers this included by default.

I can push that change direct to your fork if you like (if you give me write permissions), or can just make it again yourself if you prefer!

(For completeness, cryptoLens has not made that change upstream either... https://github.com/Cryptolens/cryptolens-cpp/blob/master/include/cryptolens/ActivationData.hpp)

[carmenfan]

Hi @carmenfan, cryptoLens (3drepo_current) has built OK on noble so I've updated the tests repo and we'll see what travis does.

I only had to make one change, and that was to add <cstdint> to ActivationData.hpp as it seems g++13 no longer considers this included by default.

I can push that change direct to your fork if you like (if you give me write permissions), or can just make it again yourself if you prefer!

(For completeness, cryptoLens has not made that change upstream either... https://github.com/Cryptolens/cryptolens-cpp/blob/master/include/cryptolens/ActivationData.hpp)

@sebjf I've transferred it to 3drepo https://github.com/3drepo/cryptolens-cpp

So feel free to make the commit 😆 thanks!