TEST: Updated parameterised tests to use attributes instead of deprecated comments.

Author: ben51degrees

tests/EnableCookiesTests.php

@@ -31,6 +31,7 @@
 use fiftyone\pipeline\core\SequenceElement;
 use fiftyone\pipeline\core\JsonBundlerElement;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\TestWith;
 
 class CookieElement extends FlowElement
 {
@@ -57,24 +58,13 @@ public function processInternal($flowData): void
 
 class EnableCookiesTests extends TestCase
 {
-    public function provider_testJavaScriptCookies()
-    {
-        return [
-            [false, false, false],
-            [true, false, false],
-            [false, true, true],
-            [true, true, true]
-        ];
-    }
-
     /**
      * Test that the cookie settings are respected correctly.
-     * 
-     * @dataProvider provider_testJavaScriptCookies
-     * @param mixed $enableInConfig
-     * @param mixed $enableInEvidence
-     * @param mixed $expectCookie
      */
+    #[TestWith([false, false, false])]
+    #[TestWith([true, false, false])]
+    #[TestWith([false, true, true])]
+    #[TestWith([true, true, true])]
     public function testJavaScriptCookies($enableInConfig, $enableInEvidence, $expectCookie)
     {
         $jsElement = new JavascriptBuilderElement([

tests/SetHeaderTests.php

@@ -31,6 +31,7 @@
 use fiftyone\pipeline\core\tests\classes\TestPipeline;
 use fiftyone\pipeline\core\Utils;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class SetHeaderTests extends TestCase
 {
@@ -80,11 +81,8 @@ public static function provider_testGetResponseHeaderValue()
 
     /**
      * Test response header value to be set for UACH.
-     *
-     * @dataProvider provider_testGetResponseHeaderValue
-     * @param mixed $device
-     * @param mixed $expectedValue
      */
+    #[DataProvider("provider_testGetResponseHeaderValue")]
     public function testGetResponseHeaderValue($device, $expectedValue)
     {
         $setHeaderPropertiesDict = [
@@ -142,11 +140,8 @@ public static function provider_testGetResponseHeaderName_Valid()
 
     /**
      * Test get response header function for valid formats.
-     *
-     * @dataProvider provider_testGetResponseHeaderName_Valid
-     * @param mixed $data
-     * @param mixed $expectedValue
      */
+    #[DataProvider("provider_testGetResponseHeaderName_Valid")]
     public function testGetResponseHeaderNameValid($data, $expectedValue)
     {
         $setHeaderElement = new SetHeaderElement();
@@ -166,11 +161,8 @@ public static function provider_testGetResponseHeaderName_InValid()
 
     /**
      * Test get response header function for valid formats.
-     *
-     * @dataProvider provider_testGetResponseHeaderName_InValid
-     * @param mixed $data
-     * @param mixed $expectedValue
      */
+    #[DataProvider("provider_testGetResponseHeaderName_InValid")]
     public function testGetResponseHeaderNameInValid($data, $expectedValue)
     {
         $setHeaderElement = new SetHeaderElement();