FEAT: JavaScriptBuilder will now minify it's output by default.

FEAT: JavaScriptBuilder will now minify it's output by default. This feature can be disabled by passing in a 'minify' parameter set to false.
TESTS: Added a test to verify that the minify step is working and is enabled by default.

Author: Steve51D

JavascriptBuilder.php

@@ -23,6 +23,8 @@
 
 namespace fiftyone\pipeline\core;
 
+use NodejsPhpFallback\Uglify;
+
 /**
  * The JavaScriptBuilder aggregates JavaScript properties
  * from FlowElements in the Pipeline. This JavaScript also (when needed)
@@ -47,6 +49,7 @@ public function __construct($settings = array())
             "_enableCookies" => isset($settings["enableCookies"]) ? $settings["enableCookies"] : true
 
         ];
+        $this->minify = isset($settings["minify"]) ? $settings["minify"] : true;
     }
 
     public $dataKey = "javascriptbuilder";
@@ -161,6 +164,12 @@ public function processInternal($flowData)
         }
 
         $output = $m->render(file_get_contents(__DIR__ . "/JavaScriptResource.mustache"), $vars);
+
+        if($this->minify) {
+            // Minify the output
+            $uglify = new Uglify(array($output)); 
+            $output = $uglify->getMinifiedJs();
+        }
 
         $data = new ElementDataDictionary($this, ["javascript" => $output]);
 

composer.json

@@ -23,7 +23,8 @@
     "license": "EUPL-1.2", 
     "type": "library",
     "require": {
-        "mustache/mustache": "^2.13"
+        "mustache/mustache": "^2.13",
+        "nodejs-php-fallback/uglify": "^1.0"
     },
     "autoload": {
         "classmap": [

tests/javascriptBuilderTests.php

@@ -70,9 +70,18 @@ public function processInternal($FlowData)
 
 class TestPipeline
 {
-    public function __construct()
+    public function __construct($minify = NULL)
     {
-        $this->Pipeline = (new PipelineBuilder())
+        if(is_null($minify))
+        {
+            $pipelineSettings = array();
+        }
+        else 
+        {
+            $jsSettings = array('minify'=>$minify);
+            $pipelineSettings = array('javascriptBuilderSettings'=>$jsSettings);
+        }
+        $this->Pipeline = (new PipelineBuilder($pipelineSettings))
         ->add(new TestEngine())
         ->build();
     }
@@ -82,7 +91,7 @@ class JavaScriptBundlerTests extends TestCase
 {
     public function testJSONBundler()
     {
-        $Pipeline = (new TestPipeline())->Pipeline;
+        $Pipeline = (new TestPipeline(false))->Pipeline;
 
         $FlowData = $Pipeline->createFlowData();
 
@@ -106,9 +115,37 @@ public function testJSONBundler()
         $this->assertEquals($FlowData->jsonbundler->json, $expected);
     }
 
-    public function testSequence()
+    public function testJavaScriptBuilder_Minify() 
     {
+        // Generate minified javascript
+        $Pipeline = (new TestPipeline(true))->Pipeline;
+        $FlowData = $Pipeline->createFlowData();
+        $FlowData->process();
+        $minified = $FlowData->javascriptbuilder->javascript;
+
+        // Generate non-minified javascript
+        $Pipeline = (new TestPipeline(false))->Pipeline;
+        $FlowData = $Pipeline->createFlowData();
+        $FlowData->process();
+        $nonminified = $FlowData->javascriptbuilder->javascript;
+
+        // Generate javascript with default settings
         $Pipeline = (new TestPipeline())->Pipeline;
+        $FlowData = $Pipeline->createFlowData();
+        $FlowData->process();
+        $default = $FlowData->javascriptbuilder->javascript;
+
+        // We don't want to get too specific here. Just check that 
+        // the minified version is smaller to confirm that it's
+        // done something.
+        $this->assertGreaterThan(strlen($minified), strlen($nonminified));
+        // Check that default is to minify the output
+        $this->assertEquals(strlen($default), strlen($minified));
+    }
+
+    public function testSequence()
+    {
+        $Pipeline = (new TestPipeline(false))->Pipeline;
 
         $FlowData = $Pipeline->createFlowData();