Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-TEST Dependency Structure #32

Open
CodeGat opened this issue Mar 19, 2025 · 6 comments
Open

ACCESS-TEST Dependency Structure #32

CodeGat opened this issue Mar 19, 2025 · 6 comments

Comments

@CodeGat
Copy link
Member

CodeGat commented Mar 19, 2025

Currently in #29 we have the ACCESS-NRI dependency structure:

access-test (the model deployment repository)
  ^ access-test-model (either the component in a coupled model (like access-om2s mom5, etc, or a model itself like access-om3-nuopc?)

There is a proposal to add a access-test-model-component to the access-test package (access-test-model?) which would lead to the heirarchy of:

access-test (the model deployment repository)
  ^ access-test-model (a model itself like access-om3-nuopc)?
    ^ access-test-model-component (a dependency of the above access-test-model model?)

Is this what is intended? Seems like we should either have a series of model components like:

access-test
  ^ access-test-model-component1
  ^ access-test-model-component2

in the access-om2 style, or:

access-test
  ^ access-test-model

in the current access-om3 style.

What is everyones thoughts?

@harshula
Copy link
Collaborator

I would expect:

access-test (MDR)
access-test (SBR)
  ^ access-test-model (SPR)

@aidanheerdegen
Copy link
Member

The fact that I haven't made PRs for the SPRs might be causing some confusion?

Done now: ACCESS-NRI/spack-packages#214

But I'll also need to make one for https://github.com/ACCESS-NRI/spack-packages/blob/main/packages/access-test/package.py to point to above

@aidanheerdegen
Copy link
Member

Spoke too soon. I had done a PR for that one already. But created ACCESS-NRI/spack-packages#215 and requested reviews

@CodeGat
Copy link
Member Author

CodeGat commented Mar 20, 2025

I've reviewed it, but am still a bit confused. How does the dependency structure look?

@aidanheerdegen
Copy link
Member

aidanheerdegen commented Mar 21, 2025

For completeness, now it is

access-test-model (MDR)
access-test-model (SBR)
  ^ access-test-component (SPR)

@harshula
Copy link
Collaborator

Hi @aidanheerdegen , I think you meant:

access-test (MDR)
access-test (SBR)
  ^ access-test-component (SPR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: New Issues 🌅
Development

No branches or pull requests

3 participants