Skip to content

Commit d46637a

Browse files
authored
Fix metrics query (#15)
* Fix metrics query * PR feedback Use logger instead of print. Don't exit early on http and prom errors.
1 parent d699be9 commit d46637a

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

benchmark_serving.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -725,14 +725,22 @@ def print_metrics(metrics: List[str], duration: float, namespace: str, job: str)
725725
# handle response
726726
if request_post.ok:
727727
if response["status"] == "success" and response["data"] and response["data"]["result"]:
728-
metric_results[query_name] = float(response["data"]["result"][0]["value"][1])
729-
logger.debug("%s: %s" % (query_name, response["data"]["result"][0]["value"][1]))
728+
r = response["data"]["result"]
729+
if not r:
730+
logger.debug(f"Failed to get result for {query_name}")
731+
continue
732+
v = r[0].get("value", None)
733+
if not v:
734+
logger.debug(f"Failed to get value for result: {r}")
735+
continue
736+
metric_results[query_name] = float(v[1])
737+
logger.debug("%s: %s" % (query_name, v[1]))
730738
else:
731739
logger.debug("Cloud Monitoring PromQL Error: %s" % (response))
732-
return server_metrics
740+
continue
733741
else:
734742
logger.debug("HTTP Error: %s" % (response))
735-
return server_metrics
743+
continue
736744
server_metrics[metric] = metric_results
737745
return server_metrics
738746

0 commit comments

Comments
 (0)