refactor: update count incrementing logic to rpc call and coderabbit fixes

Author: smokeyScraper

backend/app/agents/devrel/nodes/generate_response.py

@@ -119,7 +119,9 @@ async def _store_interaction_to_db(state: AgentState, final_response: str) -> No
 
         # Extract classification data
         classification = state.context.get("classification", {})
-        intent = classification.get("intent")
+        # TODO: intent key not present in classification schema (contains: needs_devrel, priority, reasoning)
+        # Modify prompt to include intent key
+        intent = classification.get("reasoning")  # Fallback to reasoning for intent
 
         # Store the interaction
         await store_interaction(

backend/app/database/supabase/scripts/create_db.sql

@@ -116,4 +116,27 @@ $$ language 'plpgsql';
 CREATE TRIGGER update_conversation_context_updated_at
 BEFORE UPDATE ON conversation_context
 FOR EACH ROW
-EXECUTE FUNCTION update_updated_at_column();
+EXECUTE FUNCTION update_updated_at_column();
+
+-- Migration: Add atomic increment function for user interaction count
+-- This function safely increments the total_interactions_count for a user
+
+CREATE OR REPLACE FUNCTION increment_user_interaction_count(user_uuid UUID)
+RETURNS INTEGER AS $$
+DECLARE
+    new_count INTEGER;
+BEGIN
+    -- Atomically increment the counter and return the new value
+    UPDATE users
+    SET total_interactions_count = total_interactions_count + 1
+    WHERE id = user_uuid
+    RETURNING total_interactions_count INTO new_count;
+    
+    -- Return the new count (NULL if user not found)
+    RETURN new_count;
+END;
+$$ LANGUAGE plpgsql;
+
+-- Optional: Add a comment for documentation
+COMMENT ON FUNCTION increment_user_interaction_count(UUID) IS 
+'Atomically increments the total_interactions_count for a user. Returns the new count or NULL if user not found.';

backend/app/database/supabase/services.py

@@ -139,19 +139,18 @@ async def store_interaction(
         if response.data:
             logger.info(f"Interaction stored successfully for user {user_uuid}")
 
-            # Increment user's total_interactions_count
-            # First get the current count
-            user_response = await supabase.table("users").select("total_interactions_count").eq("id", user_uuid).limit(1).execute()
-            if user_response.data:
-                current_count = user_response.data[0].get("total_interactions_count", 0)
-                await supabase.table("users").update({
-                    "total_interactions_count": current_count + 1
-                }).eq("id", user_uuid).execute()
-
+            # Atomically increment user's total_interactions_count
+            try:
+                rpc_response = await supabase.rpc("increment_user_interaction_count", {"user_uuid": user_uuid}).execute()
+                if rpc_response.data is not None:
+                    logger.debug(f"Updated interaction count for user {user_uuid}: {rpc_response.data}")
+                else:
+                    logger.warning(f"User {user_uuid} not found when incrementing interaction count")
+            except Exception as e:
+                logger.exception("Error incrementing user interaction count")
+
+            # Not failing the entire operation if incrementing the interaction count fails
             return True
-        else:
-            logger.error(f"Failed to store interaction: {response}")
-            return False
 
     except Exception as e:
         logger.error(f"Error storing interaction: {str(e)}")