When changing either "Probability of a nickname" or "Probability of a solid name", these have no effect on the actual generation of nicknames of solid names.
Steps to reproduce the behavior:
- Set "Probability of a nickname" to the far right (1.0f)
- Start the creation of a new colony
- Randomise a colonist repeatedly and a nickname is only generated a small percentage of the time
Expected behavior
A nickname should be generated every time if the probability is 100%.
Additional context
It appears that curSolidNameProbability and curNicknameProbability were set to 1.0f in d732696 instead of 0.5f and 0.15f respectively.
When changing either "Probability of a nickname" or "Probability of a solid name", these have no effect on the actual generation of nicknames of solid names.
Steps to reproduce the behavior:
Expected behavior
A nickname should be generated every time if the probability is 100%.
Additional context
It appears that curSolidNameProbability and curNicknameProbability were set to 1.0f in d732696 instead of 0.5f and 0.15f respectively.