Fix some integration tests #3755
Conversation
MDrakos
force-pushed
the
miked/CP-964
branch
8 times, most recently
from
fe2cfa1 to
0710c3e
Compare
mitchell-as
left a comment
mitchell-as
left a comment
There was a problem hiding this comment.
This looks good, but we don't need to skip ARM tests. See my comment below.
| // SkipUnsupportedArchitectures will skip tests for unsupported system architectures | ||
| func (suite *Suite) SkipUnsupportedArchitectures() { | ||
| if runtime.GOOS == "linux" && runtime.GOARCH == "arm64" { | ||
| suite.T().Skip("Skipping test on Linux/arm64 - platform not configured") | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't need this and the subsequent calls to this function in follow up tests because we'll have to add this to every integration test we tag until we have arm64 support for the projects we use.
The arm runner is for ensuring State Tool can be installed and used on ARM systems -- we have tests that do pass on ARM as part of the nightly suite.
For the time being we accept that our ARM tests will fail when we explicitly tag tests for running on CI until we get around to adding ARM support to our ActiveState-CLI test projects.
The nightly arm runner should not have any failing tests though. For example, see last night's success: https://github.com/ActiveState/cli/actions/runs/19653720289/job/56285920214
There was a problem hiding this comment.
Are the tests that pass on ARM all unit tests? The link you provided is skipping all integration tests on ARM.
I'm okay to remove this but would prefer to not have failing tests on PRs if there's an easy way to avoid it. Can we skip integration tests on PRs for arm as well or is that currently useful?
MDrakos
force-pushed
the
miked/CP-964
branch
from
0710c3e to
58a6855
Compare
No description provided.