From 7f26db42072a7844e29d6be9a03cdac8a7df8888 Mon Sep 17 00:00:00 2001 From: Kelly Downes Date: Sat, 28 Sep 2019 10:12:42 -0700 Subject: [PATCH 1/2] Complete min_heap methods --- lib/min_heap.rb | 67 ++++++++++++++++++++++++++++++++++++------------- 1 file changed, 49 insertions(+), 18 deletions(-) diff --git a/lib/min_heap.rb b/lib/min_heap.rb index 6eaa630..442f887 100644 --- a/lib/min_heap.rb +++ b/lib/min_heap.rb @@ -8,26 +8,32 @@ def initialize(key, value) end class MinHeap - def initialize @store = [] end # This method adds a HeapNode instance to the heap - # Time Complexity: ? - # Space Complexity: ? + # Time Complexity: O(log n) + # Space Complexity: O(1) def add(key, value = key) - raise NotImplementedError, "Method not implemented yet..." + @store << HeapNode.new(key, value) + + heap_up(@store.length - 1) end # This method removes and returns an element from the heap # maintaining the heap structure - # Time Complexity: ? - # Space Complexity: ? + # Time Complexity: O(log n) + # Space Complexity: O(1) def remove() - raise NotImplementedError, "Method not implemented yet..." - end + return nil if @store.empty? + + swap(0, @store.length - 1) + result = @store.pop + heap_down(0) unless @store.empty? + return result.value + end # Used for Testing def to_s @@ -39,15 +45,15 @@ def to_s end output += @store.last.value + "]" - + return output end # This method returns true if the heap is empty - # Time complexity: ? - # Space complexity: ? + # Time complexity: O(1) + # Space complexity: O(1) def empty? - raise NotImplementedError, "Method not implemented yet..." + return @store == [] end private @@ -55,17 +61,42 @@ def empty? # This helper method takes an index and # moves it up the heap, if it is less than it's parent node. # It could be **very** helpful for the add method. - # Time complexity: ? - # Space complexity: ? + # Time complexity: O(log n) + # Space complexity: O(1) def heap_up(index) - + return if @store[index].nil? || index == 0 + + parent_index = (index - 1) / 2 + + if @store[parent_index].key > @store[index].key + swap(index, parent_index) + heap_up(parent_index) + end end - # This helper method takes an index and + # This helper method takes an index and # moves it up the heap if it's smaller # than it's parent node. def heap_down(index) - raise NotImplementedError, "Method not implemented yet..." + left_child = index * 2 + 1 + right_child = index * 2 + 2 + + return if @store[left_child].nil? + + if @store[right_child].nil? + if @store[index].value > @store[left_child].value + swap(index, left_child) + end + return + end + + if @store[left_child].key < @store[right_child].key + swap(left_child, index) + heap_down(left_child) + else + swap(right_child, index) + heap_down(right_child) + end end # If you want a swap method... you're welcome @@ -74,4 +105,4 @@ def swap(index_1, index_2) @store[index_1] = @store[index_2] @store[index_2] = temp end -end \ No newline at end of file +end From 60063a38433abeb84767fbaa62c15322ecd5d41e Mon Sep 17 00:00:00 2001 From: Kelly Downes Date: Sun, 29 Sep 2019 09:30:12 -0700 Subject: [PATCH 2/2] Complete heapsort method --- lib/heap_sort.rb | 22 +++++++++++++++++----- test/heapsort_test.rb | 14 +++++++------- 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/lib/heap_sort.rb b/lib/heap_sort.rb index c8a32a4..18e7130 100644 --- a/lib/heap_sort.rb +++ b/lib/heap_sort.rb @@ -1,8 +1,20 @@ # This method uses a heap to sort an array. -# Time Complexity: ? -# Space Complexity: ? -def heap_sort(list) - raise NotImplementedError, "Method not implemented yet..." -end \ No newline at end of file +# Time Complexity: O(nlog n) +# Space Complexity: O(1) +def heapsort(list) + return list if list.length < 2 + + heap = MinHeap.new + + until list.empty? + heap.add(list.pop) + end + + until heap.empty? + list << heap.remove + end + + return list +end diff --git a/test/heapsort_test.rb b/test/heapsort_test.rb index 34402ac..9964e33 100644 --- a/test/heapsort_test.rb +++ b/test/heapsort_test.rb @@ -1,8 +1,8 @@ require_relative "test_helper" -xdescribe "heapsort" do +describe "heapsort" do it "sorts an empty array" do - # Arrange + # Arrange list = [] # Act @@ -13,7 +13,7 @@ end it "can sort a 1-element array" do - # Arrange + # Arrange list = [5] # Act @@ -22,9 +22,9 @@ # Assert expect(result).must_equal [5] end - + it "can sort a 5-element array" do - # Arrange + # Arrange list = [5, 27, 3, 16, -50] # Act @@ -32,5 +32,5 @@ # Assert expect(result).must_equal [-50, 3, 5, 16, 27] - end -end \ No newline at end of file + end +end