Branches - Amal and Julia #2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| class Channel < Recipient | ||
| attr_reader :topic, :member_count | ||
|
|
||
| def initialize(topic: , member_count: , slack_id: , name: ) | ||
| super(slack_id: slack_id, name: name) | ||
| @topic = topic | ||
| @member_count = member_count | ||
| end | ||
|
|
||
| def details | ||
| details = """ | ||
| Channel Details: | ||
| Slack ID: #{@slack_id} | ||
| Name: #{@name} | ||
| Topic: #{@topic} | ||
| Member Count: #{@member_count} | ||
| """ | ||
|
|
||
| return details | ||
| end | ||
|
|
||
| def self.list | ||
| response = self.get("https://slack.com/api/channels.list", ENV["SLACK_TOKEN"]) | ||
|
|
||
| members = response["channels"].map do |channel| | ||
| self.new(slack_id: channel["id"], name: channel["name"], topic: channel["topic"]["value"], member_count: channel["members"].length ) | ||
| end | ||
| return members | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,30 @@ | ||||||
| class Recipient | ||||||
| attr_reader :slack_id, :name | ||||||
|
|
||||||
| def initialize(slack_id: , name: ) | ||||||
| @slack_id = slack_id | ||||||
| @name = name | ||||||
| end | ||||||
|
|
||||||
| def self.get(url, params) | ||||||
| query = { | ||||||
| token: params | ||||||
| } | ||||||
|
|
||||||
| response = HTTParty.get(url, query: query) | ||||||
|
|
||||||
| if response["error"] | ||||||
|
There was a problem hiding this comment. You should also check
Suggested change
|
||||||
| raise SlackApiError.new "#{response.code}: #{response.message} -- #{response["error"]}" | ||||||
| end | ||||||
|
|
||||||
| return response | ||||||
| end | ||||||
|
|
||||||
| def details | ||||||
| raise NotImplementedError.new "Implement me in a child class!" | ||||||
|
|
||||||
| end | ||||||
|
|
||||||
| def self.list | ||||||
| raise NotImplementedError.new "Implement me in a child class!" | ||||||
| end | ||||||
| end | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,138 @@ | ||
| #!/usr/bin/env ruby | ||
| require_relative 'workspace' | ||
|
|
||
| def main | ||
| workspace = Workspace.new | ||
| # variable to format command line entry | ||
| prompt = "> " | ||
|
|
||
| puts "Welcome to the Ada Slack CLI!" | ||
| puts "The number of channels is #{workspace.channels.length}." | ||
| puts "The number of users is #{workspace.users.length}" | ||
|
|
||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
| until search == "quit" | ||
|
|
||
| case search | ||
| when "quit" | ||
| exit | ||
|
|
||
| when "list users", "users" | ||
| puts | ||
| puts "Listing Users..." | ||
| workspace.users.each do |user| | ||
| puts | ||
| puts "Username: #{user.name}" | ||
| puts "Real Name: #{user.real_name}" | ||
| puts "Slack ID: #{user.slack_id}" | ||
| end | ||
| puts | ||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
|
|
||
| when "list channels", "channels" | ||
| puts | ||
| puts "Listing Channels..." | ||
| workspace.channels.each do |channel| | ||
| puts | ||
| puts "Channel name: #{channel.name}" | ||
| puts "Topic: #{channel.topic}" | ||
| puts "Member count: #{channel.member_count}" | ||
| puts "Slack ID: #{channel.slack_id}" | ||
| end | ||
| puts | ||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
|
|
||
| when "select channel", "channel" | ||
| puts "Please enter a channel name or slack_id for the channel you would like to select:" | ||
| print prompt | ||
| input = gets.chomp | ||
|
|
||
| if workspace.select_channel(input: input) | ||
| workspace.select_channel(input: input) | ||
|
There was a problem hiding this comment. Running |
||
| puts """ | ||
| #{input} is now selected | ||
| """ | ||
| else | ||
| puts """ | ||
| No channel has that name or ID | ||
|
There was a problem hiding this comment. I would have liked to have seen this as an error until search == "quit"
begin
case search
when "list channels", "channels"
# ...
when "select channel", "channel"
puts "Please enter a channel name or slack_id for the channel you would like to select:"
print prompt
input = gets.chomp
workspace.select_channel(input: input)
puts "
#{input} is now selected
"
when "select user", "user"
puts "Please enter a username or slack_id for the user you would like to select:"
print prompt
input = gets.chomp
workspace.select_user(input: input)
puts "
#{input} is now selected
"
# other menu options...
rescue SlackWorkspaceError => error
puts e.message
end
end |
||
| """ | ||
| end | ||
|
|
||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
|
|
||
| when "select user", "user" | ||
| puts "Please enter a username or slack_id for the user you would like to select:" | ||
| print prompt | ||
| input = gets.chomp | ||
|
|
||
| if workspace.select_user(input: input) | ||
| workspace.select_user(input: input) | ||
| puts """ | ||
| #{input} is now selected | ||
| """ | ||
| else | ||
| puts """ | ||
| No user has that name or ID | ||
| """ | ||
| end | ||
|
|
||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
|
|
||
| when "details" | ||
| if workspace.show_details | ||
| puts "Here are the details for #{workspace.selected.name}:" | ||
| puts workspace.show_details | ||
| else | ||
| puts """ | ||
| No recipient is currently selected | ||
| """ | ||
| end | ||
|
|
||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
|
|
||
| when "send message", "message" | ||
| unless workspace.selected.nil? | ||
| puts "What message would you like to send to #{workspace.selected.name}?" | ||
| message = gets.chomp | ||
|
|
||
| workspace.send_message(message, workspace.selected.slack_id) | ||
|
|
||
| puts """ | ||
| Message posted! | ||
| """ | ||
| else | ||
| puts """ | ||
| No recipient selected! | ||
| """ | ||
| end | ||
|
|
||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
| else | ||
| puts """ | ||
| Invalid Command | ||
| """ | ||
| puts "Do you want to list users, list channels, select user, select channel, show details for selected, send message to selected or quit?" | ||
| print prompt | ||
| search = gets.chomp.downcase | ||
| end | ||
| end | ||
|
|
||
| puts "Thank you for using the Ada Slack CLI" | ||
| end | ||
|
|
||
| main if __FILE__ == $PROGRAM_NAME | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| class SlackApiError < StandardError; end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| class User < Recipient | ||
| attr_reader :real_name, :status_text, :status_emoji | ||
|
|
||
| def initialize(real_name:, slack_id:, name:) | ||
| super(slack_id: slack_id, name: name) | ||
| @real_name = real_name | ||
| @status_text = status_text | ||
| @status_emoji = status_emoji | ||
| end | ||
|
|
||
| def details | ||
| details = """ | ||
| User Details: | ||
| Slack ID: #{@slack_id} | ||
| Username: #{@name} | ||
| Real Name: #{@real_name} | ||
| """ | ||
|
|
||
| return details | ||
| end | ||
|
|
||
| def self.list | ||
| response = self.get("https://slack.com/api/users.list", ENV["SLACK_TOKEN"]) | ||
|
|
||
| members = response["members"].map do |member| | ||
| self.new(slack_id: member["id"], name: member["name"], real_name: member["real_name"] ) | ||
| end | ||
| return members | ||
| end | ||
| end | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,70 @@ | ||||||
| require 'httparty' | ||||||
| require 'awesome_print' | ||||||
| require 'pry' | ||||||
| require 'dotenv' | ||||||
| Dotenv.load | ||||||
|
|
||||||
| require_relative 'slack_api_error' | ||||||
| require_relative 'recipient' | ||||||
| require_relative 'channel' | ||||||
| require_relative 'user' | ||||||
|
|
||||||
| class Workspace | ||||||
| attr_reader :users, :channels, :selected | ||||||
|
|
||||||
| def initialize | ||||||
| @users = User.list | ||||||
| @channels = Channel.list | ||||||
| @selected = nil | ||||||
| end | ||||||
|
|
||||||
| def select_channel(input: nil) | ||||||
|
There was a problem hiding this comment. A keyword argument is probably overkill here. Positional parameters can be optional too.
Suggested change
Though I'm not sure it makes sense to select a channel without giving a name. |
||||||
| channel_names = @channels.map { |channel| channel.name } | ||||||
| channel_ids = @channels.map { |channel| channel.slack_id } | ||||||
|
|
||||||
| if channel_names.include?(input) | ||||||
| @selected = @channels.find { |c| input == c.name } | ||||||
| elsif channel_ids.include?(input) | ||||||
| @selected = @channels.find { |c| input == c.slack_id } | ||||||
| else | ||||||
| return nil | ||||||
|
There was a problem hiding this comment. I'd like to see this |
||||||
| end | ||||||
| return @selected | ||||||
| end | ||||||
|
|
||||||
| def select_user(input: nil) | ||||||
|
|
||||||
| usernames = @users.map { |user| user.name } | ||||||
| user_ids = @users.map { |user| user.slack_id } | ||||||
|
|
||||||
| if usernames.include?(input) | ||||||
| @selected = @users.find { |u| input == u.name } | ||||||
| elsif user_ids.include?(input) | ||||||
| @selected = @users.find { |u| input == u.slack_id } | ||||||
| else | ||||||
| return nil | ||||||
| end | ||||||
| return @selected | ||||||
| end | ||||||
|
|
||||||
| def show_details | ||||||
| return @selected.details if @selected | ||||||
| end | ||||||
|
|
||||||
| def send_message(message, channel) | ||||||
| response = HTTParty.post( | ||||||
| "https://slack.com/api/chat.postMessage", | ||||||
| body: { | ||||||
| token: ENV["SLACK_TOKEN"], | ||||||
| channel: channel, | ||||||
| text: message | ||||||
| }, | ||||||
| headers: { 'Content-Type' => 'application/x-www-form-urlencoded' } | ||||||
| ) | ||||||
|
|
||||||
| if response["error"] | ||||||
| raise SlackApiError.new "#{response.code}: #{response.message} -- #{response["error"]}" | ||||||
| end | ||||||
|
|
||||||
| return response | ||||||
| end | ||||||
| end | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triple quotes aren't needed in Ruby like they are in some other languages. Ruby does multi-line strings by default.
(In fact Ruby actually reads this as a empty string followed by a multi-line string followed by another empty string. By default in Ruby strings get joined together if they are next to each other.
greeting = "Hello," " world!"is the same asgreeting = "Hello, world!".)