Skip to content

Space - Antonia #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antoniairizarry wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Space - Antonia #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ee925
completed individual reflection
antoniairizarry Mar 28, 2020
a9b86b4
add peer review feedback
cojenco Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions feedback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Feedback Rubric

- Student Being Reviewed:
- Reviewer:
- Classroom:
- Student Being Reviewed: Antonia Irizarry
- Reviewer: Cathy Ouyang
- Classroom: Space

## Manual App Testing

Expand All @@ -17,7 +17,7 @@
1. Practices best practices working with APIs. (The .env is not checked into git, and no API token was directly used in the Ruby code without ENV.)
</td>
<td>
yes/no
yes
</td>
</tr>

Expand All @@ -26,7 +26,7 @@
2. Practices error handling with APIs. (For all pieces of code that make an API call, it handles API requests that come back with errors/error status codes appropriately.)
</td>
<td>
yes/no
yes
</td>
</tr>

Expand All @@ -35,7 +35,7 @@
3. Implements inheritance and inheritance idioms. There is a Recipient class. User and Channel inherit from Recipient. In Recipient, there are appropriate methods defined that are used in both User and Channel. Some may be implemented. Some may be template methods.
</td>
<td>
yes/no
yes; Could raise NotImplementedError for template methods in Recipient abstract class.
</td>
</tr>

Expand All @@ -51,7 +51,7 @@
</ul>
</td>
<td>
yes/no
yes; Clean code and very concise!
</td>
</tr>

Expand All @@ -60,7 +60,7 @@
5. Practices instance methods vs. class methods appropriately. (The methods to list all Channels or Users is a class method within those respective classes.)
</td>
<td>
yes/no
yes
</td>
</tr>

Expand All @@ -70,7 +70,7 @@
6. Practices best practices for testing. (The project has and uses VCR mocking when running tests, and can run offline.)
</td>
<td>
yes/no
yes
</td>
</tr>

Expand All @@ -80,7 +80,7 @@
7. Practices writing tests. (The User, Channel, and Workspace classes have unit tests.)
</td>
<td>
yes/no
yes
</td>
</tr>

Expand All @@ -90,7 +90,7 @@
8. There are also tests for sending messages (the location of these tests may differ, but is likely in Recipient)
</td>
<td>
yes/no
yes; They were in workspace tests.
</td>
</tr>

Expand All @@ -100,7 +100,7 @@
9. Practices git with at least 15 small commits and meaningful commit messages
</td>
<td>
yes/no
no
</td>
</tr>
</table>
Expand All @@ -118,31 +118,31 @@
<td>1. As a user of the CLI program, I can <strong>list</strong> users and channels with the commands <code>list users</code> and <code>list channels</code>
</td>
<td>
yes/no
yes
</td>

</tr>
<tr>
<td>2. As a user of the CLI program, I can <strong>select</strong> users and channels with the commands <code>select user</code> and <code>select channel</code>
</td>
<td>
yes/no
yes
</td>
</tr>

<tr>
<td>3. As a user of the CLI program, I can show the details of a selected user or channel with the command <code>details</code>
</td>
<td>
yes/no
yes
</td>
</tr>

<tr>
<td>4. As a user of the CLI program, when I input something inappropriately, the program runs without crashing. Example commands to try are <code>do_something</code>, or <code>select user</code> followed by <code>Mr. Fakename</code>
</td>
<td>
yes/no
yes
</td>
</tr>
</table>
Expand Down
58 changes: 29 additions & 29 deletions individual-reflection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,48 +9,48 @@ Answer the following comprehension questions **within this file.** Write your an
### `GET` Request Review

1. Describe a GET request that your project makes, and the high-level description of what it does
- Answer:
1. What is the verb of this request?
- Answer:
1. What is the path (or the URL, or endpoint) of this request?
- Answer:
1. What are the query params (the additional data sent with the request, besides the verb and the path)?
- Answer:
1. What is the syntax used to make this request? (Copy and paste a code snippet here)
- Answer: There are GET requests for getting a list of users or a list of channels depending of the end point used, HTTParty makes a call using a get method with url/endpoint and token params.
2. What is the verb of this request?
- Answer: Get
3. What is the path (or the URL, or endpoint) of this request?
- Answer: https://slack.com/api/users.list for getting a list of users.
4. What are the query params (the additional data sent with the request, besides the verb and the path)?
- Answer: token
5. What is the syntax used to make this request? (Copy and paste a code snippet here)
- Answer:
```ruby
# Copy and paste your answer below this comment

HTTParty.get(url, query: {token: ENV['SLACK_TOKEN']})
# Copy and paste your answer above this comment
```
1. What does the program do if the response comes back with a status code of 200?
- Answer:
1. What does the program do if the response does not come back with a status code of 200?
- Answer:
6. What does the program do if the response comes back with a status code of 200?
- Answer: It returns a response.
7. What does the program do if the response does not come back with a status code of 200?
- Answer: It raises an error.

### `POST` Request Review

If your project does not make a POST request, read through Wave 3 on the original Slack CLI, and research and answer questions 1, 2, 3, 4, 6, and 7.

1. Describe a POST request that your project makes, and the high-level description of what it does
- Answer:
1. What is the verb of this request?
- Answer:
1. What is the path (or the URL, or endpoint) of this request?
- Answer:
1. What are the query params (the additional data sent with the request, besides the verb and the path)?
- Answer:
1. What is the syntax used to make this request? (Copy and paste a code snippet here)
- Answer: A POST request is used to message either a channel or a user depending the selected recipient. HTTParty makes a call using a post method with the appropriate url/endpoint and body consisting of token, input text, and channel/recipient.
2. What is the verb of this request?
- Answer: Post.
3. What is the path (or the URL, or endpoint) of this request?
- Answer: https://slack.com/api/chat.postMessage
4. What are the query params (the additional data sent with the request, besides the verb and the path)?
- Answer: a body with token, text, and channel params.
5. What is the syntax used to make this request? (Copy and paste a code snippet here)
- Answer:
```ruby
# Copy and paste your answer below this comment

HTTParty.post("https://slack.com/api/chat.postMessage", body: {token: ENV['SLACK_TOKEN'], text: message, channel: @slack_id})
# Copy and paste your answer above this comment
```
1. What does the program do if the response comes back with a status code of 200?
- Answer:
1. What does the program do if the response does not come back with a status code of 200?
- Answer:
6. What does the program do if the response comes back with a status code of 200?
- Answer: It returns true.
7. What does the program do if the response does not come back with a status code of 200?
- Answer: It raises an error.

## Request & Response Cycle

Expand All @@ -62,11 +62,11 @@ There are two actors:

Based on the project requirements, when Grace enters "list channels,"
1. What is the request being made in the program?
- Answer:
- Answer: It is a GET request to list all channels, using the conversations.list endpoint.
1. Who is the client?
- Answer:
- Answer: The computer.
1. Who is the server?
- Answer:
- Answer: The Slack API

## Part 2: Optional Refactoring

Expand Down