v2.3.1 (#59)

* feat: export validator utils

* chore: bump a version

* fix(typescript): represent transaction id as a string (#52)

* fix: remove preinstall npm script (#53)

* fix: remove preinstall npm script

* chore: bump a version

* Fix/transaction query (#51)

* chore(CHANGELOG): v2.3.0

* fix: health check bugs

* fix: health check works only for one random node

* fix(healthCheck): logging non existing extra attempt

* fix(healthCheck): logging right amount of total nodes

* fix(healthCheck): node failed with `undefined` status code

* chore: fix grammar

* chore: bump a version

* docs: update changelog

Author: martiliones

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [2.3.1] - 2024-04-26
+
+### Fixed
+
+- A bug when only one random node was checked
+- Log messages for health checks
+
 ## [2.3.0] - 2024-03-01
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "adamant-api",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "description": "JavaScript API library for the ADAMANT Blockchain",
   "keywords": [
     "adm",

src/api/index.ts

@@ -204,15 +204,20 @@ export class AdamantApi extends NodeManager {
       return response.data;
     } catch (error) {
       if (error instanceof AxiosError) {
-        const logMessage = `[ADAMANT js-api] Get-request: Request to ${url} failed with ${error
-          .response?.status} status code, ${error}${
-          error.response?.data
-            ? '. Message: ' + error.response.data.toString().trim()
-            : ''
-        }. Try ${retryNo} of ${maxRetries}.`;
+        const {response} = error;
+
+        const nodeStatus = response?.status
+          ? `Request to ${url} failed with ${response.status} status code`
+          : `Node ${url} hasn't returned its status`;
+
+        const logMessage = `[ADAMANT js-api] Get-request: ${nodeStatus}, ${error}${
+          response?.data ? '. Message: ' + response.data.toString().trim() : ''
+        }.`;
 
         if (retryNo <= maxRetries) {
-          logger.log(`${logMessage} Retrying…`);
+          logger.log(
+            `${logMessage} Try ${retryNo} of ${maxRetries}. Retrying…`
+          );
 
           await this.updateNodes();
           return this.request<T>(method, endpoint, data, retryNo + 1);

src/helpers/healthCheck.ts

@@ -116,8 +116,10 @@ export class NodeManager {
 
     const {length: activeNodesCount} = activeNodes;
     if (!activeNodesCount) {
+      const totalNodesCount = this.options.nodes.length;
+
       logger.error(
-        `[ADAMANT js-api] Health check: All of ${activeNodesCount} nodes are unavailable. Check internet connection and nodes list in config.`
+        `[ADAMANT js-api] Health check: All of ${totalNodesCount} nodes are unavailable. Check internet connection and nodes list in config.`
       );
       return;
     }
@@ -215,7 +217,7 @@ export class NodeManager {
     );
   }
 
-  async getNodeStatus(node: string) {
+  async checkNode(node: string) {
     try {
       const {timeout} = this.options;
 
@@ -239,13 +241,13 @@ export class NodeManager {
     for (const node of nodes) {
       const start = unixTimestamp();
 
-      const response = await this.getNodeStatus(node);
+      const response = await this.checkNode(node);
 
       const ping = unixTimestamp() - start;
 
       if (!response.success) {
         this.logger.log(
-          `[ADAMANT js-api] Health check: Node ${node} haven't returned its status`
+          `[ADAMANT js-api] Health check: Node ${node} hasn't returned its status`
         );
         continue;
       }