-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues on Firefox #23
Comments
Still an issue 😢 |
Hey i noticed that you're using custom confetti particles as well. Could your issue be related to what I'm experiencing in #26? |
We fixed this for a promo by adding a frame limiter to the animation loop and capping it at 30fps instead of whatever Firefox was willing to hand over to it. Line 210's call to requestAnimationFrame just needs to be wrapped in a setTimeout. |
Ohh great, I will test that! Sorry for the late reply!! |
Took someone's Frankenstein branch: https://github.com/DreamTeamMobile/confetti-js/commits/svg-preload Fixes both these issues, which the maintainer hasn't gotten around to merging: Agezao/confetti-js#23 Agezao/confetti-js#26
@enrickla do you see the same problem on https://agezao.github.io/confetti-js/? If not can you provide a URL that shows the problem? |
Hey! So everything seems fine on android and iOS but I got serious slow performance on Firefox after 10-15 sec and it's getting worst overtime.
Here is my code (
"confetti-js": "0.0.17"
):Is this problem related?
https://gamedev.stackexchange.com/questions/37298/slow-firefox-javascript-canvas-performance
The text was updated successfully, but these errors were encountered: