Skip to content

DPL: improve arrow::Dataset integration#13725

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:pr13725
Nov 24, 2024
Merged

DPL: improve arrow::Dataset integration#13725
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:pr13725

Conversation

@ktf
Copy link
Member

@ktf ktf commented Nov 23, 2024

  • Modularise filesystem to allow easier navigation and support for
    multiple formats.
  • Add initial support to multiplex multiple tables on top of the same tree.
  • Improve support for writing boolean fields.

@ktf ktf requested a review from a team as a code owner November 23, 2024 09:51
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild alibuild mentioned this pull request Nov 23, 2024
Closed
@alibuild
Copy link
Collaborator

alibuild commented Nov 23, 2024

Error while checking build/O2/fullCI for 475d25f at 2024-11-23 11:45:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(arrow::NumericArray<arrow::UInt8Type>*&)'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:96:17: error: 'arrow::PrimitiveArray::PrimitiveArray()' is protected within this context
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:95:23: error: 'arrow::PrimitiveArray::PrimitiveArray()' is protected within this context
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:119:7: error: 'arrow::PrimitiveArray::PrimitiveArray()' is protected within this context
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Nov 24, 2024

Error while checking build/O2/fullCI for f37b9d7 at 2024-11-24 11:31:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(arrow::NumericArray<arrow::UInt8Type>*&)'
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:96:17: error: 'arrow::PrimitiveArray::PrimitiveArray()' is protected within this context
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:95:23: error: 'arrow::PrimitiveArray::PrimitiveArray()' is protected within this context
/sw/slc8_x86-64/GCC-Toolchain/v13.2.0-alice1-6/include/c++/13.2.0/bits/stl_construct.h:119:7: error: 'arrow::PrimitiveArray::PrimitiveArray()' is protected within this context
ninja: build stopped: subcommand failed.

Full log here.

@ktf
DPL: improve arrow::Dataset integration
cc0b2f8 
- Modularise filesystem to allow easier navigation and support for
  multiple formats.
- Add initial support to multiplex multiple tables on top of the same tree.
- Improve support for writing boolean fields.
@ktf ktf merged commit 6cfdeae into AliceO2Group:dev Nov 24, 2024
@ktf
Copy link
Member Author

ktf commented Nov 24, 2024

Errors unrelated. Only affects a working test. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @alibuild