From e6a0bf3a5d752792eb9d552d6d3fd14630bd74df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADt=20Ku=C4=8Dera?= Date: Thu, 22 May 2025 15:59:16 +0200 Subject: [PATCH] Fix bugs found by cppcheck - `Invalid abs() argument nr 1. A non-boolean value is required. [invalidFunctionArgBool]` - `Shifting 32-bit value by 63 bits is undefined behaviour [shiftTooManyBits]` --- PWGJE/Core/JetTaggingUtilities.h | 2 +- PWGJE/Tasks/trackJetQA.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PWGJE/Core/JetTaggingUtilities.h b/PWGJE/Core/JetTaggingUtilities.h index 2f3d9a67d11..ab399bb852d 100644 --- a/PWGJE/Core/JetTaggingUtilities.h +++ b/PWGJE/Core/JetTaggingUtilities.h @@ -350,7 +350,7 @@ int jetOrigin(T const& jet, U const& particles, float dRMax = 0.25) typename U::iterator parton1; typename U::iterator parton2; for (auto const& particle : particles) { - if (std::abs(particle.getGenStatusCode() == 23)) { + if (std::abs(particle.getGenStatusCode()) == 23) { if (!firstPartonFound) { parton1 = particle; firstPartonFound = true; diff --git a/PWGJE/Tasks/trackJetQA.cxx b/PWGJE/Tasks/trackJetQA.cxx index a66bc0e8c0d..f0549a0a0e3 100644 --- a/PWGJE/Tasks/trackJetQA.cxx +++ b/PWGJE/Tasks/trackJetQA.cxx @@ -272,7 +272,7 @@ struct TrackJetQa { histos.fill(HIST("TrackPar/signed1Pt"), track.pt(), track.sigma1Pt() * track.pt(), track.signed1Pt(), collision.centFT0A(), collision.centFT0C()); histos.fill(HIST("TrackPar/snp"), track.pt(), track.sigma1Pt() * track.pt(), track.snp(), collision.centFT0A(), collision.centFT0C()); histos.fill(HIST("TrackPar/tgl"), track.pt(), track.sigma1Pt() * track.pt(), track.tgl(), collision.centFT0A(), collision.centFT0C()); - for (unsigned int i = 0; i < 64; i++) { + for (unsigned int i = 0; i < 32; i++) { if (track.flags() & (1 << i)) { histos.fill(HIST("TrackPar/flags"), track.pt(), track.sigma1Pt() * track.pt(), i); }