Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpleusb-tune-menu is replacing empty devstr= with a device string #328

Open
jxmx opened this issue May 15, 2024 · 7 comments
Open

simpleusb-tune-menu is replacing empty devstr= with a device string #328

jxmx opened this issue May 15, 2024 · 7 comments

Comments

@jxmx
Copy link
Member

jxmx commented May 15, 2024

If /etc/asterisk/simpleusb.conf starts out with an empty devstr=, is it expected that simpleusb-tune-menu will will then populate devstr= with a fixed value? In testing the Pi image, I was running one type of radio board. I swapped it out for a different one and spent a few minutes trying to figure out why the sound card wasn't working right. The devstr= which started out from the stock/default empty changed from from 1-1.5:1-0 to 1-1.2:1.0 with the only thing that would have edited it was simpleusb-tune-menu. Editing /etc/asterisk/simpleusb.conf to clear out devstr= fixed it, but running simpleusb-tune-menu writes the device string right back to simpleusb.conf. I think this is a bug?

@jxmx
Copy link
Member Author

jxmx commented May 15, 2024

@tsawyer @KB4MDD

@tsawyer
Copy link
Member

tsawyer commented May 15, 2024

running simpleusb-tune-menu writes the device string right back to simpleusb.conf. I think this is a bug?

I believe it's intended behavior to allow for additional USB devices. Maybe there needs to be an option to clear the devstr to allow auto discovery once again.

@KB4MDD
Copy link
Collaborator

KB4MDD commented May 15, 2024

The current operation is the original intended behavior. See issue #284 . Originally, the default configs contained a device string. That string would not work for all users. We changed the sample configs to have a blank device string. When the user plugs in the device, chan_simpleusb and chan_usbradio will recognize the blank device string and assign the first unused CM108 device.

The channel drivers, upon receiving a command to save the settings, writes out the current device string setting to the configuration file.

The device string really needs to be populated after setup. On a node with multiple devices, we need the string to associate the node with the correct device.

I agree with Tim - if a user is replacing a device and it is not recognized with the same device string, we would want some mechanism to reset the device string to blank for a given node. That would cause the internal device discovery mechanism to work.

@jxmx
Copy link
Member Author

jxmx commented May 15, 2024

Sounds good.

@jxmx jxmx closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
@tsawyer
Copy link
Member

tsawyer commented May 15, 2024

@jxmx Sounds like a simple menu option. Do you want to leave it open for a next release... not this beta?

@tsawyer tsawyer reopened this May 15, 2024
@KB4MDD KB4MDD removed their assignment Jul 12, 2024
@Allan-N
Copy link
Collaborator

Allan-N commented Dec 6, 2024

Re: a "simple menu option" What are we thinking?

Or, do we just need to make sure that the tune menu's "S) Swap Current USB device with another USB device" options work?

@jxmx
Copy link
Member Author

jxmx commented Dec 8, 2024

I think the latter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants