Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m_has_rays in libs/rover/ray_generators/{ray_generator,camera_generator} issues #1464

Open
brugger1 opened this issue Mar 4, 2025 · 0 comments

Comments

@brugger1
Copy link
Contributor

brugger1 commented Mar 4, 2025

I noticed there is a member m_has_rays in the ray_generator class. It is always set to false in camera_generator, which seems incorrect. I assume it should only be set to false if there are actually no rays generated. The only place m_has_rays is used is in RayGenerator::get_has_rays, which is never called in the entire code base.

Assuming this is an issue, either the function and variable can be removed or the code in camera_generator can be fixed. It should probably also be set in visit_generator.

I'm happy to fix if it is an issue and if we decide which of the two paths to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant