Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Minimal #21

Open
walkero-gr opened this issue Jan 5, 2023 · 6 comments
Open

Building Minimal #21

walkero-gr opened this issue Jan 5, 2023 · 6 comments
Assignees

Comments

@walkero-gr
Copy link
Collaborator

The next step for WebKit port is to work on the compilation of minimal browser, which is configured in Makefile.

@walkero-gr walkero-gr self-assigned this Jan 5, 2023
@walkero-gr walkero-gr converted this from a draft issue Jan 5, 2023
@walkero-gr
Copy link
Collaborator Author

Right now I am stuck with the webkit minibrowser port on 55% of the compilation. Attached is a log file of the errors I am having. I have a feeling that something crucial is missing from our dev environment. I don't know what yet.

errors.zip

@kas1e
Copy link

kas1e commented Jul 16, 2023

Checked the errors.zip, and first error i see is "error: redefinition of ‘struct WTF::Lock’" , as it from webkit do have "struct Lock" too, which we do have in dos/dosextens.h. So or you need to rename it in webkit, but of course that will produce crap and issues, so better to fix it by maybe providing on configuring stage a "-D__USE_AMIGAOS_NAMESPACE__" flag.

Probably, fixing this will auto-fix many other ones declarations errors (as they may based on this one). But whole set of errors in this log looks like something simple happens, like needs to add include somewhere, or so. Just with c++ and especially webkit, it always brings mess of errors even for a simple issue.

@walkero-gr
Copy link
Collaborator Author

@kas1e Thank you so much for having a look at that. I tested adding the -D__USE_AMIGAOS_NAMESPACE__ flag but this brought more errors at a very early stage of the compilation. Unfortunately, it didn't solve the errors.
I hope the problem will be something simple and we will find it soon. We dig into it.

If you think anything else that could help feel free to contact us. Every help matters a lot.

@walkero-gr
Copy link
Collaborator Author

Thanks to @kas1e we found the fix for the issue that gives us all these errors and now the minibrowser build compiles to 99%

7b1b6e6

@raziel-
Copy link

raziel- commented Oct 30, 2023

i applaud you, well done...

/back to lurking and watching this space

@walkero-gr
Copy link
Collaborator Author

Now we have the WebCore library compile 100%. I started working on a minimal window which will be able to show the webview with one website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants