Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 2023-05-02 + VM run #1

Open
3 tasks
igornishka opened this issue May 2, 2023 · 2 comments
Open
3 tasks

Review 2023-05-02 + VM run #1

igornishka opened this issue May 2, 2023 · 2 comments

Comments

@igornishka
Copy link
Member

igornishka commented May 2, 2023

  • you can review readme before pushing e.g. here
  • dump intermediate data e.g. the 20M sampled sentences
  • fix passing arguments via the script to be able to better control the file naming
@igornishka igornishka changed the title Review 2023-05-02 Review 2023-05-02 + VM run May 3, 2023
@igornishka
Copy link
Member Author

igornishka commented May 3, 2023

During the clean installation and running on the VM, I encountered the following:

  • wikisimple_folder = $data_folder/Model_English_C_English_S doesn't work due to the space -> wiki simple says: Saving to: '/WikiSimple.tar.gz -> tar: NMT-Data/Model_English_C_English_S/WikiSimple.tar.gz: Cannot open: No such file or directory
  • sudo apt-get install unzip as it's a bit annoying, it gets flooded by the rest of the script output
  • let's check if we can exit on error in this whole script or deal with the output differently
  • FileNotFoundError: [Errno 2] No such file or directory: 'NMT-Data/Eval_Medical_Dutch_C_Dutch_S/NL_test_org' -> I completely forgot this one, so maybe we can make things fool-proof and check if the eval data (or anything else that's needed) is there in the beginning and exit if that's not the case?

@igornishka
Copy link
Member Author

igornishka commented May 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant