Assumptions about database file placement

[ChristopherPAndrews]

It appears that there is an assumption that sqlite files will be found in the current working directory of Node when it is launched. This is a problem partly because of the documentation. It is suggested that the migration is run local to the knex file, and that the app be launched from the main Middguard directory. This results in two different databases.

Short term fix would be to alter the docs to be consistent.
Longer term fix would be to come up with either a standardized DB location or a way for it to be specified in the configuration.

[danasilver]

I think it makes more sense to use Knex's solution (process.cwd() + name) unless an absolute path is provided. That makes sense for most users where the Knexfile and server aren't in a subdirectory. It also means that a Knexfile works exactly the same as it usually does outside MiddGuard.

Running ./bin/middguard migrate --knexfile examples/simple/knexfile.js from the middguard top level directory should work and result in one database. I always work from the top level directory.

Docs can definitely be improved, especially for the case where you're working on MiddGuard itself. I'll put a little work into that.

[ChristopherPAndrews]

Having been playing with it, I now think it is primarily a documentation issue. The solution of path.join(__dirname,...) provides what I think of as the correct behavior. The fix that we could make would be to check if the database exists (since we are expecting migrations to be run first). The problem I had was that I ran the migration and then moved to a different directory to start the app and it created a second database without complaining (though it didn't have all of the right tables in it).

[I have not been running from the top level directory because I started our vast2016 project as external to middguard's structure altogether. So far it is working.]