accessibility: add SortAnnouncer for aria-live sorting updates across tables#389
Closed
onyekachi66 wants to merge 1 commit into
Closed
accessibility: add SortAnnouncer for aria-live sorting updates across tables#389onyekachi66 wants to merge 1 commit into
onyekachi66 wants to merge 1 commit into
Conversation
Contributor
|
Closing — this branch's SortAnnouncer/aria-live accessibility work is already on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145
Description
This PR improves accessibility for screen-reader users by adding a reusable, visually-hidden
SortAnnouncercomponent that utilizes anaria-live="polite"region. When a user changes the sorting order or cycles back to an unsorted state in the table headers, the live region automatically announces the changes (e.g., "Sorted by Amount, ascending" or "Sorting cleared").Key Changes
useEffecthook that avoids triggering screen-reader announcements on initial mount.PoolTable.test.tsxwhere it was expecting"Pools search and refresh"instead of the actual"Pools search"role label, and updated its query scope to search for the sibling Refresh button globally rather than inside the search region.Verification
All 27 targeted tests across
AnchorTable.test.tsx,PoolTable.test.tsx, andSettlementTable.test.tsxpass successfully.