Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow print media queries #11

Open
PaulSmithTrick14 opened this issue Mar 29, 2021 · 2 comments
Open

Allow print media queries #11

PaulSmithTrick14 opened this issue Mar 29, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@PaulSmithTrick14
Copy link
Contributor

Breakpoints have the mediatype hard coded to be screen. It is currently not possible to have a valid media query which references a different mediatype.

Removing that hard coding allows a breakpoint to be added like this

'breakpoints': (
  ... // as per existing
  'print': 'print'
)

making it easier to control the print layout.

I have a pull request ready (my first one ever!) for this change if there is any interest.

@Andy-set-studio
Copy link
Owner

Let's do it, Paul! I have just defaulted to screen out of laziness so I'm very up for it being more useful.

@Andy-set-studio Andy-set-studio added the enhancement New feature or request label Mar 29, 2021
@mario-fehr
Copy link

@hankchizljaw as this was fixed with #12 this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants