#267 Issue: Update whats.py #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input 'wait_time - 4' for time.sleep() function on line 38 was causing a problem as for wait_time <4 it will be a negative value which is not accepted by time.sleep() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats.py may crash as time.sleep() function doesn't accept negative integers
Closes issue number #267
The issue has a syntax error by the user but upon looking over it, I found an error in whats.py. In line 38, time.sleep() function takes wait_time-4 as an argument but this will raise an error and will crash the script when the user feeds a number less than 4 as a value for wait_time, as time.sleep() cannot take negative integer as argument