Skip to content

cps2ds sometimes introduces ownerless Vars #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leissa opened this issue Mar 20, 2024 · 2 comments
Closed

cps2ds sometimes introduces ownerless Vars #271

leissa opened this issue Mar 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@leissa
Copy link
Member

leissa commented Mar 20, 2024

I'm 99% sure it's also broken on current master but most of the time we won't notice because the ownerless Var will be optimized away. However, we sometimes have the effect on master that things break as soon as you print sth. This is the reason for this. I fixed one issue in #269 but this one here remains: `

./bin/thorin ../lit/direct/ad_mem.thorin.disabled2 -p clos    

Speaking of this: Why is there also lit/direct/ad_mem.thorin.disabled?

@leissa leissa added the bug Something isn't working label Mar 20, 2024
@leissa leissa mentioned this issue Mar 20, 2024
leissa added a commit that referenced this issue Apr 3, 2024
removed old ad_mem.thorin.disabled
see #271
@leissa
Copy link
Member Author

leissa commented Apr 3, 2024

  • removed old ad_mem.thorin.disabled and moved ad_mem.thorin.disabled2 -> ad_mem.thorin.disabled
  • there is also ad_mem2.thorin.disabled. do we need this?
  • both tests are a mess and we should probably come up with simpler tests that provoke the bug

@leissa
Copy link
Member Author

leissa commented Feb 18, 2025

Closing for now as test case is hopelessly outdated.

@leissa leissa closed this as completed Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant