fix: prevent fd leak in TraversalType2 implementation

Johnson-zs · Johnson-zs · commit 27a3b2a6c52c · 2025-11-10T10:43:07.000+08:00
diff --git a/src/libappimage/core/impl/TraversalType2.cpp b/src/libappimage/core/impl/TraversalType2.cpp
@@ -52,6 +52,7 @@ class TraversalType2::Priv {
         rootInodeId = sqfs_inode_root(&fs);
         err = sqfs_traverse_open(&trv, &fs, rootInodeId);
         if (err != SQFS_OK) {
+            sqfs_fd_close(fs.fd);
             sqfs_destroy(&fs);
             throw IOError("sqfs_traverse_open error");
         }
@@ -60,6 +61,7 @@ class TraversalType2::Priv {
     virtual ~Priv() {
         sqfs_traverse_close(&trv);
 
+        sqfs_fd_close(fs.fd);
         sqfs_destroy(&fs);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ class TraversalType2::Priv {`
`52`	`52`	`rootInodeId = sqfs_inode_root(&fs);`
`53`	`53`	`err = sqfs_traverse_open(&trv, &fs, rootInodeId);`
`54`	`54`	`if (err != SQFS_OK) {`
	`55`	`+ sqfs_fd_close(fs.fd);`
`55`	`56`	`sqfs_destroy(&fs);`
`56`	`57`	`throw IOError("sqfs_traverse_open error");`
`57`	`58`	`}`
`@@ -60,6 +61,7 @@ class TraversalType2::Priv {`
`60`	`61`	`virtual ~Priv() {`
`61`	`62`	`sqfs_traverse_close(&trv);`
`62`	`63`
	`64`	`+ sqfs_fd_close(fs.fd);`
`63`	`65`	`sqfs_destroy(&fs);`
`64`	`66`	`}`
`65`	`67`