Skip to content

Commit a87da6b

Browse files
committed
fix: prevent fd leak in TraversalType2 implementation
1 parent f8f106b commit a87da6b

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/libappimage/core/impl/TraversalType2.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
extern "C" {
99
#include <squashfuse.h>
1010
#include <squashfs_fs.h>
11+
#include <squashfuse/util.h>
1112
}
1213

1314
// system
@@ -52,15 +53,21 @@ class TraversalType2::Priv {
5253
rootInodeId = sqfs_inode_root(&fs);
5354
err = sqfs_traverse_open(&trv, &fs, rootInodeId);
5455
if (err != SQFS_OK) {
56+
sqfs_fd_t fd = fs.fd;
5557
sqfs_destroy(&fs);
58+
sqfs_fd_close(fd);
5659
throw IOError("sqfs_traverse_open error");
5760
}
5861
}
5962

6063
virtual ~Priv() {
6164
sqfs_traverse_close(&trv);
6265

66+
sqfs_fd_t fd = fs.fd;
67+
6368
sqfs_destroy(&fs);
69+
70+
sqfs_fd_close(fd);
6471
}
6572

6673
bool isCompleted() const {

0 commit comments

Comments
 (0)