-
Notifications
You must be signed in to change notification settings - Fork 372
Docs: add example conda environment and installation troubleshooting #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @aymaneVXx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the installation experience for Evo 2 by introducing a standardized and reproducible conda environment configuration. It also provides clear, actionable troubleshooting guidance within the documentation to help users resolve common setup issues, aiming to reduce friction for new users and minimize recurring support questions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great addition to improve the user installation experience. I've found a couple of areas for improvement. In environment.yml, the flash-attn package should be installed via pip to ensure the correct version is used, as it's not available on the specified conda channels. In README.md, the new troubleshooting section has some markdown formatting issues that I've suggested fixes for to improve readability. Overall, these changes will be very helpful for new users.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR improves the installation experience for Evo 2 by:
environment.ymlwith a reproducible conda setup (Python 3.12, CUDA 12.1, PyTorch 2.5.1, Transformer Engine, FlashAttention, Vortex).transformer_engine,vortex, and CUDA/NVRTC library issues.These changes are intended to help new users create a working environment more easily and reduce repeated installation-related questions in existing GitHub issues.