Failing to open ftxui-screen.lib on Windows with GitHub Actions & CPM

[szymonj99]

I'm able to compile locally, but my project fails to compile when running with GitHub Actions on windows-latest in either debug or release modes.
I am using CPM, but the same has happened when using FetchContent manually.

Error

Generating Code...
LINK : fatal error LNK1181: cannot open input file 'Release\ftxui-screen.lib' [D:\a\...\build\_deps\ftxui-build\dom.vcxproj]

Setup

CPMAddPackage("gh:ArthurSonzogni/FTXUI#764c24ef4046fbfd3cb1a25d0cb8a47a84e82d3a")
...
target_link_libraries(${PROJECT_NAME} PRIVATE ... ftxui::screen ftxui::dom ftxui::component)

ftxui-screen.dll seems to be generated correctly:

Generating Code...
  screen.vcxproj -> D:\a\OneControl\OneControl\build\_deps\ftxui-build\Release\ftxui-screen.dll
  Building Custom Rule D:/a/OneControl/OneControl/build/_deps/ftxui-src/CMakeLists.txt

Let me know if this is an issue on my end 💯

[ArthurSonzogni]

What's your github action?

There is likely a problem. You can probably take some inspiration from:

FTXUI/.github/workflows/build.yaml

Lines 35 to 37 in 764c24e

	- name: Windows MSVC
	os: windows-latest
	compiler: cl

FTXUI/.github/workflows/build.yaml

Lines 39 to 73 in 764c24e

	runs-on: ${{ matrix.os }}
	steps:
	- name: "Checkout repository"
	uses: actions/checkout@v2
	- name: "Setup Cpp"
	uses: aminya/setup-cpp@v1
	with:
	compiler: ${{ matrix.compiler }}
	vcvarsall: ${{ contains(matrix.os, 'windows' )}}
	cmake: true
	ninja: true
	clangtidy: true
	cppcheck: false
	gcovr: true
	opencppcoverage: true
	# make sure coverage is only enabled for Debug builds, since it sets -O0
	# to make sure coverage has meaningful results
	- name: "Configure CMake"
	run: >
	cmake -S .
	-B ./build
	-DCMAKE_BUILD_TYPE:STRING=Debug
	-DFTXUI_ENABLE_COVERAGE:BOOL=ON
	-DFTXUI_BUILD_DOCS:BOOL=OFF
	-DFTXUI_BUILD_EXAMPLES:BOOL=ON
	-DFTXUI_BUILD_TESTS:BOOL=ON
	-DFTXUI_BUILD_TESTS_FUZZER:BOOL=OFF
	-DFTXUI_ENABLE_INSTALL:BOOL=ON ;
	- name: "Build"
	run: >
	cmake
	--build ./build

[szymonj99]

My action is as follows (BUILD_TYPE is Release):

build-windows-release:
    runs-on: windows-latest

    steps:
    - uses: actions/checkout@v2

    - name: Configure CMake
      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}

    - name: Build
      run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}

I'll give your suggestion a try and report back.
Thanks! 💯

[szymonj99]

Unfortunately, your suggestion doesn't seem to have worked for me so far.
Below is my updated workflow file. Let me know if I missed something 💯

name: CMake

on:
  push:
    branches: [ '*' ]

env:
  BUILD_TYPE: Release

jobs:
  compiling:
    name: "Compiling"
    strategy:
      matrix:
        include:
          - name: Windows
            os: windows-latest
            compiler: cl

          - name: Linux GCC
            os: ubuntu-latest
            compiler: gcc

          - name: MacOS Clang
            os: macos-latest
            compiler: llvm

    runs-on: ${{ matrix.os }}
    steps:
      - name: Checkout Repository
        uses: actions/checkout@v2

      - name: Setup C++
        uses: aminya/setup-cpp@v1
        with:
          # Let's add `clangtidy: true` and maybe other possible checks here in the future.
          compiler: ${{ matrix.compiler }}
          #vcvarsall: ${{ contains(matrix.os, 'windows' )}} # I'm not 100% sure what this is tbh.
          cmake: true
          ninja: true

      - name: Download Packages
        if: ${{ contains(matrix.os, 'ubuntu' )}}
        run: sudo apt update && sudo apt install libx11-dev libsfml-dev xorg-dev libopengl-dev mesa-common-dev libudev-dev libopenal-dev libvorbis-dev libflac-dev libncurses-dev
        shell: bash

      - name: Configure CMake
        run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}

      - name: Build
        run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}

[ArthurSonzogni]

What happens if you replace:

target_link_libraries(${PROJECT_NAME} PRIVATE ... ftxui::screen ftxui::dom ftxui::component)

by:

target_link_libraries(${PROJECT_NAME} PRIVATE ftxui::screen ftxui::dom ftxui::component)

I don't understand what are the "..." This might be the issue.

[szymonj99]

Oh, could be! I didn't think of that 😄
It implies other dependencies I have in my project.
I'll try that and report back 💯

[szymonj99]

Just as a heads-up, the full line is this:
target_link_libraries(${PROJECT_NAME} PRIVATE sfml-network fmt::fmt-header-only argh spdlog::spdlog_header_only ftxui::screen ftxui::dom ftxui::component)