Screen::Cursor::shape is uninitialized when used

[dylanhart]

• Screen::cursor_ is created using the default constructor of Screen::Cursor
• Screen::Cursor::shape is not set in the default constructor
• shape is later used without being set in places like ScreenInteractive::Draw(Component)

This has caused crashes and other weird behavior in some of my builds.

Related issues: #937 #602

---

Possible fix:

@@ -105,7 +105,7 @@ class Screen {
       BarBlinking = 5,
       Bar = 6,
     };
-    Shape shape;
+    Shape shape = Shape::Hidden;
   };
   Cursor cursor() const { return cursor_; }
   void SetCursor(Cursor cursor) { cursor_ = cursor; }

[tobywenman]

Hey, I just bumped into this too, it was generating a bunch of Valgrind warnings in one of my projects.

Turns out that cmake has a feature to apply patches to fetchContent which works pretty well for me. Your fix works just fine.

project(ftxui-patch)

set(ftxui-patch git apply ${CMAKE_CURRENT_SOURCE_DIR}/patches/ftxui-cursorShape.patch)

include(FetchContent)
set(FETCHCONTENT_UPDATES_DISCONNECTED TRUE)
FetchContent_Declare(ftxui
  GIT_REPOSITORY https://github.com/ArthurSonzogni/ftxui
  GIT_TAG v5.0.0
  PATCH_COMMAND ${ftxui-patch}
)
FetchContent_MakeAvailable(ftxui)