Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include old messages in a chain when replying #3

Open
samcamwilliams opened this issue Apr 12, 2019 · 18 comments
Open

Include old messages in a chain when replying #3

samcamwilliams opened this issue Apr 12, 2019 · 18 comments
Labels
enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue. good first issue Good for newcomers

Comments

@samcamwilliams
Copy link
Contributor

When pressing the 'reply' button on the message view page we should include the contents of the previous message in the compose pain as so:

[USER CURSOR STARTS HERE]

---
From: [PREVIOUS MESSAGE SENDER ADDRESS]
Signed at: [TIMESTAMP (if available)]

[PREVIOUS MESSAGE HERE]

This should be a fairly simple change around here.

We should also increase the default vertical size of the compose pain in order to accommodate the increased amount of text it will typically show.

@samcamwilliams samcamwilliams added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue. and removed help wanted Extra attention is needed labels Apr 12, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.5 ETH (82.14 USD @ $164.27/ETH) attached to it as part of the ArweaveTeam fund.

@samcamwilliams
Copy link
Contributor Author

Bitcoin bounty page: https://gitcoin.co/issue/ArweaveTeam/weavemail/3/2800
Reward at present time: ~$80

@iamonuwa
Copy link

Am starting work on this one now.

@gitcoinbot
Copy link

gitcoinbot commented Apr 12, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) iamonuwa has been approved to start work.

Declaring interest in getting this done now. ETA 3 hours

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@codi45
Copy link
Contributor

codi45 commented Apr 19, 2019

hi i can provide a PR

@gitcoinbot
Copy link

gitcoinbot commented Apr 19, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months from now.
Please review their action plans below:

1) codi45 has been approved to start work.

add field for previous Message in permamail,
then add content with views.js

Learn more on the Gitcoin Issue Details page.

@codi45
Copy link
Contributor

codi45 commented Apr 19, 2019

PR get merged with the previous one for UNIXTIMESTAMP
Please let me know if i should used another one

@ldmberman
Copy link
Member

Was addressed in #7.

@codi45
Copy link
Contributor

codi45 commented Apr 21, 2019

Hi @ldmberman could you please valid my applied for work on gitcoin so i could submit thanks

@samcamwilliams
Copy link
Contributor Author

Done @codi45 !

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.5 ETH (86.79 USD @ $173.58/ETH) has been submitted by:

  1. @codi45

@samcamwilliams please take a look at the submitted work:


@codi45
Copy link
Contributor

codi45 commented Apr 27, 2019

Hi @ldmberman how would you like to style the subject line.
i have added some label in the default view message and also in the previous_page for reply
i have tested correctly the json object for version 0.0.2 with subject and body data
for messages without subject and old format , the field is left empty and data is fetched correctly

@ldmberman
Copy link
Member

@codi45 I think it makes sense to style them similarly to how "Mail recipient" and "Mail content" are styled on the "Write a new permamail" page.

@codi45
Copy link
Contributor

codi45 commented May 11, 2019

Hi @samcamwilliams I think you forgot to valid this bounty thanks

@samcamwilliams
Copy link
Contributor Author

Thanks, @codi45 ! Validating it now.

@ldmberman and I are also starting a DAO to govern the development of weavemail. We will use it to vote on merging PRs etc., if there is every contention. We would like to give you some tokens for contributing. Do you have an Ethereum metamask wallet we can send some governance tokens to?

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.5 ETH (104.03 USD @ $208.07/ETH) attached to this issue has been approved & issued to @codi45.

@codi45
Copy link
Contributor

codi45 commented May 15, 2019

Hi @samcamwilliams yes sure, Thanks 0x2f08F8112325639F2FB86A5841eE16D905FAf718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants