forked from ionos-cloud/cluster-api-provider-proxmox
-
Notifications
You must be signed in to change notification settings - Fork 3
Multi template selection in ClusterClass (non-breaking) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
holmesb
wants to merge
16
commits into
Atoms:main
Choose a base branch
from
holmesb:multiple-node-templates-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a60121d to
094fb4e
Compare
094fb4e to
8f9ce93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Great work on your localStorage feature. This PR adds it to ClusterClasses via new optional topology variables, eg:
When defined per above, ProxmoxMachineTemplates get localStorage added and set to true. Also templateSelector is added, and sourceNode & templateID are removed.
Without a templateSelector or localStorage defined, behaviour is same as now: PMTs keep explicit fields patched from cloneSpec.machineSpec.*.{sourceNode,templateID}.
No controller code changes are required for this PR; it’s purely ClusterClass templates + docs.
Users following the current examples (with sourceNode/templateID) don’t need to change anything.
I’ve added/updated docs/advanced-setups.md with a short section explaining how to use templateSelector & localStorage when defining a class-powered cluster.
I’ve opened this as a Draft to make it easy for you to review and iterate without pressure. If you’re comfortable, feel free to merge into your PR branch now so reviewers can test the end-to-end ClusterClass flow from a single branch. If you prefer to keep it separate until your main PR lands in ionos-cloud, can leave it Draft and rebase after your merge - your call.
Relates to issue ionos-cloud/capmox ionos-cloud#575 - ClusterClass templateSelector (keeps explicit mode as default).