Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly select which adbusters to support #2

Open
mjangda opened this issue Nov 7, 2013 · 1 comment
Open

Explicitly select which adbusters to support #2

mjangda opened this issue Nov 7, 2013 · 1 comment

Comments

@mjangda
Copy link
Member

mjangda commented Nov 7, 2013

Sites should have to select which adbusters they want served and any others should return a 403 error. No point in serving adbusters that a VIP doesn't want/need.

@natebot
Copy link
Contributor

natebot commented Dec 15, 2013

This PR allows selection via a filter but it doesn't return a 403. I opted to just return out of the function like it does elsewhere, which results in a 404.

Were you thinking that a control panel could be provided for managing the adbusters? If so, is there a plugin that you'd suggest I use as an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants