is_rtl considered harmful
#216
Comments
|
Why do we have |
I think this is just so we can have the information in the available languages screen. At runtime it's dealt with by loading the language locale information, not doing some crazy parsing of PHP to avoid loading it. 😄 |
|
I thought so, so if it's only for showing information then why bot removing it? I assume the user would know if the language is RTL or not 😉 |
|
Removing it is another solution. Thinking. |
|
Hard coding a list of languages in Babble in some way, seems best. |
|
It’s a pity GlotPress’s list still isn’t in core: |
|
I'd completely forgotten that core uses an I'll check the RTL languages for core and see if they all use it. |
simonwheatley
added a commit
that referenced
this issue
Jul 10, 2015
* develop: Remove the reliance on `$lang.php` and use our static list of RTL languages. See #216. Introduce a static list of RTL languages from GlotPress and Wikipedia. This query doesn't contribute to the pre-caching of the subsequent `get_post()` calls, because they've already been fetched by `bbl_get_default_lang_post()` above. Fixes #251. If a term doesn't have a transid, allow it to fall through so one is created rather than throwing an exception. Remove the unused term resyncing functionality which hasn't been used since #106. Validate the content lang and interface lang before setting them. See #227. Remove error suppression on the term editing screen. See #223. Remove error suppression when saving language options or viewing the language options admin screen. See #223. Remove unnecessary theme functionality from the base `Babble_Plugin` class. See #223. Avoid throwing exceptions in `Babble_Taxonomies::get_transid()` and `Babble_Taxonomies::set_transid()`. See #218. Make the `$name` parameter in `Babble_Plugin::setup()` a required parameter, avoid throwing an exception. See #218. Avoid throwing an exception in `is_public_lang()`. Now accepts a language object or a language code string. See #218. Conflicts: class-taxonomy.php
|
Closing in favour of #216 |
|
@johnbillion you closed this in favour of itself? |
|
Whoops, #298 |
Where's the ‘like’ button on this thing? |
simonwheatley
added a commit
that referenced
this issue
Jul 13, 2015
* develop: (47 commits) Correct a test name. Travis config: Added `sudo: false` to use modern infrastructure Remove the reliance on `$lang.php` and use our static list of RTL languages. See #216. Introduce a static list of RTL languages from GlotPress and Wikipedia. Tests for post translations. See #236. Remove a bunch of unused code. Remove empty post IDs from the `$post_ids` array. Remove unnecessary use of global API functions, use current object methods instead. `Babble_Post_Public::get_post_translations()` must always return an array of `WP_Post` objects. Retain the deletion of the old post translation cache keys so they don't stay in memory in perpetuity. This query doesn't contribute to the pre-caching of the subsequent `get_post()` calls, because they've already been fetched by `bbl_get_default_lang_post()` above. Fixes #251. If a term doesn't have a transid, allow it to fall through so one is created rather than throwing an exception. Remove the unused term resyncing functionality which hasn't been used since #106. Correctly exit with non-zero if there are syntax errors when testing on Travis. See #286. Ignore Composer lock and vendor directory Validate the content lang and interface lang before setting them. See #227. Remove error suppression on the term editing screen. See #223. Remove error suppression when saving language options or viewing the language options admin screen. See #223. Remove unnecessary theme functionality from the base `Babble_Plugin` class. See #223. Avoid throwing exceptions in `Babble_Taxonomies::get_transid()` and `Babble_Taxonomies::set_transid()`. See #218. ...
simonwheatley
added a commit
that referenced
this issue
Aug 5, 2015
* develop: (127 commits) Fix merge issues in `class-taxonomy.php` More test coverage for post and term translations. Correctly flush term translation caches. Switch to using transids for term translation cache keys. Travis config: Travis config: Added `sudo: false` to use modern infrastructure Correct a test name. Travis config: Added `sudo: false` to use modern infrastructure Babble_Locale: Use an exploit priority, rather than null Babble_Taxonomies: Change from add_action method to core function Babble_Languages: Change from add_action method to core function Remove the reliance on `$lang.php` and use our static list of RTL languages. See #216. Introduce a static list of RTL languages from GlotPress and Wikipedia. Add tests to check post and term translations after adding a new translation. Use database query numbers as tests to ensure our post and term translation caching is working as expected. Add caching to `Babble_Taxonomies::get_term_translations()`. Avoids a call to `get_objects_in_term()`. See #246. Tests for term translations, and change `Babble_Taxonomies::get_term_translations()` so it returns real term objects. Tests for post translations. See #236. Remove a bunch of unused code. Remove empty post IDs from the `$post_ids` array. Remove unnecessary use of global API functions, use current object methods instead. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently our
is_rtlfunction parses (eugh) any locale file and checks for RTL. Instead we should just hardcode the RTL languages into an array (really, how often is a new one going to come along), and allow the dev to filter it so they can add any special case they may require.The text was updated successfully, but these errors were encountered: