Image CDN: Prevent warning when WP global is null (#45015)

Author: tbradsha

projects/plugins/jetpack/changelog/fix-jetpack-prevent_warning_when_global_is_null

@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Image CDN: Prevent PHP warnings when handling malformed data. 

projects/plugins/jetpack/modules/photon-cdn.php

@@ -77,30 +77,34 @@ public static function cdnize_assets() {
 
 		if ( self::is_public_version( $version ) ) {
 			$site_url = trailingslashit( site_url() );
-			foreach ( $wp_scripts->registered as $handle => $thing ) {
-				if ( wp_startswith( $thing->src, self::CDN ) ) {
-					continue;
-				}
-				if ( ! is_string( $thing->src ) ) {
-					continue;
-				}
-				$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
-				if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ), true ) ) {
-					$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
-					$wp_scripts->registered[ $handle ]->ver = null;
+			if ( $wp_scripts instanceof WP_Scripts && is_array( $wp_scripts->registered ) ) {
+				foreach ( $wp_scripts->registered as $handle => $thing ) {
+					if ( wp_startswith( $thing->src, self::CDN ) ) {
+						continue;
+					}
+					if ( ! is_string( $thing->src ) ) {
+						continue;
+					}
+					$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
+					if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ), true ) ) {
+						$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
+						$wp_scripts->registered[ $handle ]->ver = null;
+					}
 				}
 			}
-			foreach ( $wp_styles->registered as $handle => $thing ) {
-				if ( wp_startswith( $thing->src, self::CDN ) ) {
-					continue;
-				}
-				if ( ! is_string( $thing->src ) ) {
-					continue;
-				}
-				$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
-				if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ), true ) ) {
-					$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
-					$wp_styles->registered[ $handle ]->ver = null;
+			if ( $wp_styles instanceof WP_Styles && is_array( $wp_styles->registered ) ) {
+				foreach ( $wp_styles->registered as $handle => $thing ) {
+					if ( wp_startswith( $thing->src, self::CDN ) ) {
+						continue;
+					}
+					if ( ! is_string( $thing->src ) ) {
+						continue;
+					}
+					$src = ltrim( str_replace( $site_url, '', $thing->src ), '/' );
+					if ( self::is_js_or_css_file( $src ) && in_array( substr( $src, 0, 9 ), array( 'wp-admin/', 'wp-includ' ), true ) ) {
+						$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'c/%1$s/%2$s', $version, $src );
+						$wp_styles->registered[ $handle ]->ver = null;
+					}
 				}
 			}
 		}
@@ -195,27 +199,31 @@ public static function cdnize_plugin_assets( $plugin_slug, $current_version ) {
 			return false;
 		}
 
-		foreach ( $wp_scripts->registered as $handle => $thing ) {
-			if ( wp_startswith( $thing->src, self::CDN ) ) {
-				continue;
-			}
-			if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
-				$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
-				if ( in_array( $local_path, $assets, true ) ) {
-					$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
-					$wp_scripts->registered[ $handle ]->ver = null;
+		if ( $wp_scripts instanceof WP_Scripts && is_array( $wp_scripts->registered ) ) {
+			foreach ( $wp_scripts->registered as $handle => $thing ) {
+				if ( wp_startswith( $thing->src, self::CDN ) ) {
+					continue;
+				}
+				if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
+					$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
+					if ( in_array( $local_path, $assets, true ) ) {
+						$wp_scripts->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
+						$wp_scripts->registered[ $handle ]->ver = null;
+					}
 				}
 			}
 		}
-		foreach ( $wp_styles->registered as $handle => $thing ) {
-			if ( wp_startswith( $thing->src, self::CDN ) ) {
-				continue;
-			}
-			if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
-				$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
-				if ( in_array( $local_path, $assets, true ) ) {
-					$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
-					$wp_styles->registered[ $handle ]->ver = null;
+		if ( $wp_styles instanceof WP_Styles && is_array( $wp_styles->registered ) ) {
+			foreach ( $wp_styles->registered as $handle => $thing ) {
+				if ( wp_startswith( $thing->src, self::CDN ) ) {
+					continue;
+				}
+				if ( wp_startswith( $thing->src, $plugin_directory_url ) ) {
+					$local_path = substr( $thing->src, strlen( $plugin_directory_url ) );
+					if ( in_array( $local_path, $assets, true ) ) {
+						$wp_styles->registered[ $handle ]->src = sprintf( self::CDN . 'p/%1$s/%2$s/%3$s', $plugin_slug, $current_version, $local_path );
+						$wp_styles->registered[ $handle ]->ver = null;
+					}
 				}
 			}
 		}