Skip to content

Commit ca5cc2c

Browse files
Merge pull request #12258 from hasezoey/addTypesModelRemove
fix(types): add parameter "options" to "Model.remove"
2 parents 1284e68 + 3a14bef commit ca5cc2c

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

test/types/models.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -447,6 +447,12 @@ function gh12100() {
447447
})();
448448

449449

450+
function modelRemoveOptions() {
451+
const cmodel = model('Test', new Schema());
452+
453+
cmodel.remove({}, {});
454+
}
455+
450456
async function gh12286() {
451457
interface IUser{
452458
name: string;

types/models.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ declare module 'mongoose' {
113113
wtimeout?: number;
114114
}
115115

116+
interface RemoveOptions extends SessionOption, Omit<mongodb.DeleteOptions, 'session'> {}
117+
116118
const Model: Model<any>;
117119
interface Model<T, TQueryHelpers = {}, TMethodsAndOverrides = {}, TVirtuals = {}, TSchema = any> extends
118120
NodeJS.EventEmitter,
@@ -392,6 +394,7 @@ declare module 'mongoose' {
392394
): Promise<any>;
393395

394396
remove<ResultDoc = HydratedDocument<T, TMethodsAndOverrides, TVirtuals>>(filter?: any, callback?: CallbackWithoutResult): QueryWithHelpers<any, ResultDoc, TQueryHelpers, T>;
397+
remove<ResultDoc = HydratedDocument<T, TMethodsAndOverrides, TVirtuals>>(filter?: any, options?: RemoveOptions, callback?: CallbackWithoutResult): QueryWithHelpers<any, ResultDoc, TQueryHelpers, T>;
395398

396399
/** Creates a `replaceOne` query: finds the first document that matches `filter` and replaces it with `replacement`. */
397400
replaceOne<ResultDoc = HydratedDocument<T, TMethodsAndOverrides, TVirtuals>>(

0 commit comments

Comments
 (0)