-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix(tsd): correct expectError usage for newUser._id #15766 #15767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
THE-Amrit-mahto-05
wants to merge
19
commits into
Automattic:master
Choose a base branch
from
THE-Amrit-mahto-05:fix-tsd-id-type-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(tsd): correct expectError usage for newUser._id #15766 #15767
THE-Amrit-mahto-05
wants to merge
19
commits into
Automattic:master
from
THE-Amrit-mahto-05:fix-tsd-id-type-error
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e30b9c to
16d588d
Compare
Author
|
@vkarpov15 please review my PR |
Author
|
@vkarpov15 all issue fixed please review my pr |
Author
|
@vkarpov15 all checks cleared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TypeScript type error test for newUser._id in tsd tests.
The existing test used invalid syntax:
expectError((_id: number) = newUser._id)
This has been replaced with the correct callback syntax:
expectError(() => { const _id: number = newUser._id; });
This ensures that TypeScript correctly flags assignments of ObjectId to number while keeping the tsd tests valid.
Before:
expectError((_id: number) = newUser._id);
After:
expectError(() => {
const _id: number = newUser._id;
});
The previous syntax caused confusion and TypeScript would not correctly catch the type error. This fix aligns the test with valid tsd usage.